Re: [hatari-devel] beautify sdl-gui underlines patch

[David Savinkoff <dsavnkff@xxxxxxxxx>]

Hi,

Your patch is an improvement, I like it but I won't
complain if you don't apply it. Enclosed is a picture.

The up and down arrows represent vertical, the left
and right represent horizontal resolution. This is
intuitive, and the 'x' could be removed.

----- Eero Tamminen wrote:
> Hi,
> 
> On tiistai 03 helmikuu 2015, David Savinkoff wrote:
> > The following are more observations (not suggestions):
> > 
> > I noticed an 'x' beside 'Max zoomed win:' in the picture
> > I sent previously 'Best-Hatari-v1.8.0.png'. I also noticed
> > this 'x' beside the VDI size buttons, and finally figured
> > that its meaning is to use the 'up' and 'down' arrow keys.
> 
> It's just the visual 'x' symbol from "<width> x <height>",
> it has nothing to do with keyboard shortcuts. :-)
> 
> 
> > Note that the 'up' and 'down' arrow key symbols exist
> > in hatari/src/gui-sdl/font5x8.bmp and could be used.
> 
> I'm not sure it's a good idea, it looks a bit weird.
> Try the attached patch.
> 
> 
> > Also, the two lower arrow buttons could be underlined
> > to provide a hint.
> 
> NAK.  Underline doesn't fit into arrow box.
> 
> Btw. Common keyboard shortcuts like these are already listed
> in the Hatari manual page and I just added section on them
> also to the HTML manual.
> 
> 
> 	- Eero
>  
> > ----- David Savinkoff wrote:
> > > Hi,
> > > 
> > > The sdl-gui looks good. Thanks. Enclosed is a picture
> > > to compare with the previous I sent.
> > > 
> > > Sincerely,
> > > David Savinkoff
> > > 
> > > ----- Eero Tamminen wrote:
> > > > Hi,
> > > > 
> > > > I think this needs opinions from others.
> > > > 
> > > > On maanantai 02 helmikuu 2015, David Savinkoff wrote:
> > > > > Good thing you said no, because this one is better.
> > > > 
> > > > First you were saying that you want shortcut indicator to be less
> > > > visible, but your new patch makes it much more visible?
> > > > 
> > > > 
> > > > I saw from your screenshots what I think you had an issue with,
> > > > underlines going over the text on next line.  What about attached
> > > > patch?
> > > > 
> > > > With it the underline in non-zoomed mode doesn't go over next line
> > > > text (like currently), it doesn't go over button border (like in
> > > > your previous patch).  And it uses more visible color (in non-zoomed
> > > > mode) because otherwise underline could be mistook for a badly
> > > > rendered font.
> > > > 
> > > > 	- Eero
>

Attachment: Screenshot1-Hatari-v1.8.0.png
Description: PNG image