Re: [hatari-devel] Blitter / IDE issue with Hatari

[ Thread Index | Date Index | More Archives ]


On tiistai 30 syyskuu 2014, Nicolas Pomarède wrote:
> Le 28/09/2014 23:51, Nicolas Pomarède a écrit :
> > Can't say, maybe it was more for debugging purpose when writing/testing
> > ide.c
> > It's quite unlikely that any correct program will access memory above
> > $ff0040 ; even so, having just a log in m68000.c should be enough for
> > such rare cases.
> I see you sent your changes, but you removed the bus error printf in the
> "put" cases, while changing them as LOG in the "get" cases. I think you
> can remove them too in the "get" cases.

Write cases can be done with single logging as all info is know
at function start.

For read case, you need at least two logging lines, either:
1. first showing call and second return value
   - if you want them on same line, error path needs
    third log call to add missing newline
2. one showing error path and another successful call

I opted for 2) as that's nicer output with less log lines.

	- Eero

Mail converted by MHonArc 2.6.19+