Re: [hatari-devel] MacOsX Patch for full Screen

[Bob Carpenter <hatari@xxxxxxxxxx>]

Jerome,

I had no problems with adding the full screen quit fix to the current Hatari code. Thanks. That will eliminate a problem that I have run into in the past. However, when I added the diffs from your other diff file to the current Hatari code, it does not retain my preference if it was a preference that does not need to reset Hatari.

For instance, if I tell Hatari to not show the status bar, Hatari simply ignores my request and leaves the preference checked. However, if I combine the show status bar change with changing the monitor from color to mono, then the status bar change is retained because Hatari was forced to reboot. I saw the same problem on many of the menu items (select a disk from the Disks preference, changing the YM Voices Mixing to another option, and many others).

I did notice the reboots in the previous version, but I was not sure they happened every time so I did not want to report the problem without seeing a pattern. I did not attempt to do your xib and nib changes that appeared in your diff file but they appeared to be simply removing the non-working keyboard shortcuts.

If you do not see the problem and you can change the options on the Disks, Display, and Sound preferences and have Hatari retain the changes, then I can assume I made an error making your changes to the current development code.

It is sometimes hard to see in email, but I really do appreciate the work that Cocoa Pod and you have done on the OS X interface. 



Bob C


On Jun 9, 2014, at 3:09 PM, Jerome Vernet <vernet.jerome@xxxxxxxxxx> wrote:

> Hi,
> 
> Another bunch of patch:
> - each time you close preference panel, Hatari was rebooting (was calling to Change_CopyChangedParamsToConfiguration always with trye a needreset)
> - added all type of disk (mst, ipf, etc) to open box
> - cleanup of some code
> 
> https://www.dropbox.com/s/nb4l7bcyyhprno3/src.gui-osx.09052014.diff
> 
> Jerome
> 
> 
> 
> 
>