Re: [hatari-devel] TT emulation

[Thomas Huth <th.huth@xxxxxx>]

Am Fri, 13 Jul 2012 13:03:54 +0000
schrieb "Konador, Cyprian" <cyprian.konador@xxxxxx>:

> > -----Original Message-----
> > From: Konador, Cyprian
> > Sent: Thursday, July 12, 2012 13:18 PM
> > To: hatari-devel@xxxxxxxxxxxxxxxxxxx
> > Subject: RE: [hatari-devel] TT emulation
> > 
> > > -----Original Message-----
> > > From: Eero Tamminen
> > > Sent: Wednesday, July 11, 2012 19:13 PM
> > > To: hatari-devel@xxxxxxxxxxxxxxxxxxx
> > > Subject: Re: [hatari-devel] TT emulation
> > >
> > [...]
> > > In general it looks OK to me.  Here are couple of quick comments:
> > >
> > > * bTTSampleHold is used in Videl drawing code, but it doesn't
> > > seem to be zeroed if user switches to Falcon emulation (which
> > > also uses videl code).  This the only real issue.
> > 
> > Ok, I'll correct that.
> > 
> > 
> > > * Only bTTSampleHold seems need to be global, i.e. it seems that
> > >   bTThypermono should be static...
> > 
> > Ok, I'll move bool bTTHypermono from screen.h to video.c as static
> > bool. I thought about that and wasn't sure if its ok. Finally I put
> > both TT special video modes together in one file.
> > 
> > 
> > > * rest of videl.c code uses different brace ('{}') positioning
> > > convention[1] than your patch.
> > >
> > > [1] Different files in Hatari sources use different  conventions
> > > depending on their originating project and who has written /
> > > maintains them.
> > 
> > Ok, I'll correct that.
> > 
> > 
> > > > In additional, I attached test application for SampleHold and TT
> > > > Hypermono mode.
> > >
> 
> 
> Please find diff after correction.

Patch looks good now, thanks for the update! I've applied it to the
repository now.
One more minor problem: It seems like the new video states are not
restored correctly when loading a memory snapshot. Could you please
have a look at this?

 Thanks,
  Thomas