Re: [eigen] OuterstrideMatch in src/Core/Ref.h

[Dale Lukas Peterson <hazelnusse@xxxxxxxxx>]

I will see what I can do to create a MWE. Any thoughts on why ninja/make check passes with or without the patch?

On Tue, Dec 8, 2020, 1:46 PM Rasmus Munk Larsen <rmlarsen@xxxxxxxxxx> wrote:

Dale, could you send a minimal reproducer of the issue. Preferably file an issue at https://gitlab.com/libeigen/eigen/-/issues

On Tue, Dec 8, 2020 at 9:16 AM Dale Lukas Peterson <hazelnusse@xxxxxxxxx> wrote:

Hi folks,
  We use Eigen at work and are trying to integrate the recent v3.3.9
release. Everything in our codebase builds and passes tests with the
exception of one set of numerical tests which only pass if we apply
the attached patch. This patch effectively ignores
PlainObjectBase::IsVectorAtCompileTime for the purposes of
OuterStrideMatch. I don't fully understand this part of Eigen nor the
failing code internally at my company. However, with this patch
applied, the check target behaves identically to without having it
applied so I am at a bit of a loss as to whether it is really safe for
us to apply.

Are there any eigen devs out there who can speak to this part of Eigen
and give any feedback on whether this patch would be reasonable or
not?

Sincerely,
Luke