[eigen] Isometry is not being initialized like Affine?

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]

To: eigen <eigen@xxxxxxxxxxxxxxxxxxx>
Subject: [eigen] Isometry is not being initialized like Affine?
From: Greg Coombe <greg.coombe@xxxxxxxxx>
Date: Fri, 11 Jan 2019 23:19:05 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=BNkSOLC9yjxyuLIevTDPiMAF7KX6qsxFZmLWJ3hdTHw=; b=LPjgSN5Lq56lVDjFHRAJLYcEBv52uhx7ZUZdFtyJ2tvRsCcYn1Fyf1QUjWYm5077yE L+FkpPGeRDKwUStu1Ny3Rrxk44ae28/KES4pOoqW62oj96WDzyvV/XrflEX4cgacbVdF uc7SrVLClwd3hukHwT1lCl/NnRqsm6TOrxZipy/N5LpZzuvB3M4C6lCTYBwb6Uad8B/D 3zc4gsRSF4JmiGGhTlBUVZoP0+7WHvZVr66Dm/6rVx157aK/ORmZ16BvY69g9XTDPT7T 1uquzUK0ZiPOW4e9p4+lQ9Es8I8mqszIOoe4M35+D+eQEzM1RCs9Ahy63domDEO0BdMv mHoQ==

Both the isometric and affine transforms have an implicit 3rd row of [0, 0, 0, 1]. It looks like the constructor is initializing this properly for Affine, but not for Isometry.

I added some tests specifically for Isometry and Affine which verify this.

Greg

Attachment: coombe_initialize_isometry.patch
Description: Binary data

Follow-Ups:
- Re: [eigen] Isometry is not being initialized like Affine?
  - From: Gael Guennebaud

Messages sorted by: [ date | thread ]
Prev by Date: Re: [eigen] Avoid SVD in rotation() for Isometry
Next by Date: Re: [eigen] Avoid SVD in rotation() for Isometry
Previous by thread: Re: [eigen] Fwd: unsubscribe
Next by thread: Re: [eigen] Isometry is not being initialized like Affine?

Mail converted by MHonArc 2.6.19+

http://listengine.tuxfamily.org/