| Re: [eigen] Hyperplane::signedDistance incorrect |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
Ah, my mistake, looks like I failed to properly read the documentation.
I had assumed it was describing the plane as a normal and the distance to the plane from the origin traveling in the direction of the normal.
Apologies for the false bug report.
Luke
> On 1 Nov 2018, at 14:10, Christoph Hertzberg <chtz@xxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> I don't think so. In Eigen the hyperplane is defined as the set of points `x` for which `normal.dot(x) + offset == 0`, i.e., the signed distance is as implemented.
>
> With your patch the geo_hyperplane unit test will fail.
>
> Christoph
>
> On 2018-11-01 14:15, Luke Pitt wrote:
>> Hi
>> I believe that there is an error in the signedDistance member function of the Hyperplane. I believe it should subtract the offset from the dot product of the normal and the point instead of adding it.
>> I've attached a patch file. I hope I've generated the file correctly as I have only used git before and not Mercurial.
>> Thanks
>> Luke
>
> --
> Dr.-Ing. Christoph Hertzberg
>
> Besuchsadresse der Nebengeschäftsstelle:
> DFKI GmbH
> Robotics Innovation Center
> Robert-Hooke-Straße 5
> 28359 Bremen, Germany
>
> Postadresse der Hauptgeschäftsstelle Standort Bremen:
> DFKI GmbH
> Robotics Innovation Center
> Robert-Hooke-Straße 1
> 28359 Bremen, Germany
>
> Tel.: +49 421 178 45-4021
> Zentrale: +49 421 178 45-0
> E-Mail: christoph.hertzberg@xxxxxxx
>
> Weitere Informationen: http://www.dfki.de/robotik
> -----------------------------------------------------------------------
> Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
> Firmensitz: Trippstadter Straße 122, D-67663 Kaiserslautern
> Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster
> (Vorsitzender) Dr. Walter Olthoff
> Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes
> Amtsgericht Kaiserslautern, HRB 2313
> Sitz der Gesellschaft: Kaiserslautern (HRB 2313)
> USt-Id.Nr.: DE 148646973
> Steuernummer: 19/672/50006
> -----------------------------------------------------------------------
>