Re: [eigen] PATCH: Guard CUDA includes with EIGEN

yes, but what are the true errors? Without CUDA, those files should still be usable (for instance I can build on ARM device with nothing cuda related installed). At some point we'll have to cleanup those files to move the generic/SSE/AVX parts to somewhere else, like util/half.h, arch/AVX/half.h, etc.

gael

On Sat, Jul 21, 2018 at 10:48 PM Anush Elangovan <anush@xxxxxxx> wrote:

Gael,
This is still a problem in top of master. CPU half float support is provided by code in Core/arch/GPU.

Thanks
Anush

On Wed, Jul 18, 2018 at 4:56 AM, Gael Guennebaud <gael.guennebaud@xxxxxxxxx> wrote:
Hi,

sorry for late reply. The handling of CUDA has been significantly changed recently in the default branch. If there is still compilation issues, please post here the exact compilation error so that we can properly fix them. For instance, there should be no problem in including Half.h and the likes without CUDA.

gael

On Fri, Jun 15, 2018 at 6:14 AM Anush Elangovan <anush@xxxxxxx> wrote:
Please find attached a patch that prevents compiling Eigen on an embedded platform because some CUDA headers were not guarded and collided with native types.

PS: Posting here because I gave up trying to figure out bitbucket's UI and hg's issues with submitting a pull request. The patch is also on github at https://github.com/powderluv/eigen/commit/9377c80050d62c1b3c250fdf395ecfbd9cb15afc

Thanks
Anush