| Re: [eigen] Eigen warning. |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Eigen warning.
- From: Sergiu Dotenco <sergiu.dotenco@xxxxxxxxx>
- Date: Thu, 28 Jan 2016 12:28:42 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=sdxYsUDCGbRsSkBhYRgJFG/G+nTgETHhWF7XLZEeWcg=; b=UI4dIU1K8rc8igXXjtUA6IqcDUb0lUzJl9bbNkUs37F2txBLKzb1QgiuBHKoxqJkTo LiiIJz96gvy7e9Vv2WBzB0P6PVf+MCFKsd3NSNdw+25peCWDvbCrMGVaLUrardLhr0Xu 1bRnCO/7ttIkauTtciEpunoTYHDgJcOd9anvkbTIcq4rVSU1SdoQ3u7XZWXnJP9ML3Dr CZu2uFYwy+0m++RDjTNuSLZTD4y/CC/Aajsf2cwN8J9wmK7sy8UjzD+DRHAIEA6cHV06 nN5m9GrBB/Zrab04pTM4Oi04kF9++PdFA/ZbYfXsOTOmoukC5VdxIOabCPwcS1P5KzMy Shsw==
Thanks!
On 28.01.2016 12:17, Gael Guennebaud wrote:
> oops, the links were not correct:
>
> https://bitbucket.org/eigen/eigen/commits/451f6085cbd3/
> https://bitbucket.org/eigen/eigen/commits/96a1ca76e239/
>
> gael
>
> On Thu, Jan 28, 2016 at 12:15 PM, Gael Guennebaud
> <gael.guennebaud@xxxxxxxxx <mailto:gael.guennebaud@xxxxxxxxx>> wrote:
>
> Thanks. I applied slightly different fixes:
>
> https://bitbucket.org/eigen/eigen/commits/f2e6b911501d/
> https://bitbucket.org/eigen/eigen/commits/96a1ca76e239/
>
> gael
>
>
> On Thu, Jan 28, 2016 at 12:05 AM, Sergiu Dotenco
> <sergiu.dotenco@xxxxxxxxx <mailto:sergiu.dotenco@xxxxxxxxx>> wrote:
>
> On 1/27/2016 10:32 PM, Gael Guennebaud wrote:
> >
> > On Wed, Jan 27, 2016 at 7:50 PM, Billy Araujo <billyaraujo@xxxxxxxxx <mailto:billyaraujo@xxxxxxxxx>
> > <mailto:billyaraujo@xxxxxxxxx <mailto:billyaraujo@xxxxxxxxx>>> wrote:
> >
> > warning C4800: '__int64' : forcing value to bool 'true' or 'false'
> > (performance warning)
> >
> >
> > and what can we do to workaround this stupid warning? Replace the enum
> > by a static bool ?
>
> Unfortunately, this is not what causes the problem. It's the
> static test
> function that actually expects a bool but receives an __int64.
> Hence the
> warning. There are also warnings caused by _isnan usage.
>
> I've attached patches that fix both problems. At least they seem
> to work
> for me.
>
>
>