Re: [eigen] Eigen warning.

[Gael Guennebaud <gael.guennebaud@xxxxxxxxx>]

oops, the links were not correct:

https://bitbucket.org/eigen/eigen/commits/451f6085cbd3/

https://bitbucket.org/eigen/eigen/commits/96a1ca76e239/

gael

On Thu, Jan 28, 2016 at 12:15 PM, Gael Guennebaud <gael.guennebaud@xxxxxxxxx> wrote:

Thanks. I applied slightly different fixes:

https://bitbucket.org/eigen/eigen/commits/f2e6b911501d/

https://bitbucket.org/eigen/eigen/commits/96a1ca76e239/ 

gael

On Thu, Jan 28, 2016 at 12:05 AM, Sergiu Dotenco <sergiu.dotenco@xxxxxxxxx> wrote:

On 1/27/2016 10:32 PM, Gael Guennebaud wrote:
>
> On Wed, Jan 27, 2016 at 7:50 PM, Billy Araujo <billyaraujo@xxxxxxxxx
> <mailto:billyaraujo@xxxxxxxxx>> wrote:
>
>     warning C4800: '__int64' : forcing value to bool 'true' or 'false'
>     (performance warning)
>
>
> and what can we do to workaround this stupid warning? Replace the enum
> by a static bool ?

Unfortunately, this is not what causes the problem. It's the static test
function that actually expects a bool but receives an __int64. Hence the
warning. There are also warnings caused by _isnan usage.

I've attached patches that fix both problems. At least they seem to work
for me.