Re: [eigen] Call for cmake expert

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]


Thanks a lot Hauke for your valuable feedback. I'll backport it then.

On Fri, Dec 19, 2014 at 11:17 AM, Hauke Heibel <hauke.heibel@xxxxxxxxx> wrote:
Since you were actually only asking about the value in terms of back-porting, let me try again. There are two aspects.

1) It is mostly useful for people who build their personal Eigen version but it is less important for teams sharing a Eigen version on a network drive. People who want to use this functionality have still to adapt CMAKE_PREFIX_PATH.

2) What is definitely useful about this feature is the fact that it allows to configure pre-processor definitions. This is most valuable since by using a common configuration file, you can ensure that all you libs using Eigen use the same configurations (SIMD config, row vs. column major, etc.).

So specifically considering point 2) it might be well worth backporting this patch.

Regards,
Hauke



On Fri Dec 19 2014 at 10:46:04 AM Hauke Heibel <hauke.heibel@xxxxxxxxx> wrote:
I added some comments. I might be able to test the changes next week - today is the last day before holidays so it's as usual quite busy.

- Hauke

On Fri Dec 19 2014 at 10:26:46 AM Gael Guennebaud <gael.guennebaud@xxxxxxxxx> wrote:

Hi,

is there any cmake expert here who could check that the following patch is worth backporting to the 3.2 branch ?


Thank you,
Gael

Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/