| Re: [eigen] Call for cmake expert |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen <eigen@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [eigen] Call for cmake expert
- From: Hauke Heibel <hauke.heibel@xxxxxxxxx>
- Date: Fri, 19 Dec 2014 10:17:52 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:from:date:message-id:subject:to :content-type; bh=2fHaRSxpM8JF3b//7Jxj96e1Wthce+1Ag3Vwsqa65xk=; b=plEw1B3lw3ceLnx5HrSdqGikVgluW4qHnkE+mDPjvUlewkHkW9GE7kpapHzyTu0pWP nAdFcfkBH83KYmfZ+GSpZne2DqD65ZVVGka5ppZ2qZShAURh10rgGYI8R4zV6tvXqdyv tyv3+WmFOSE8ohda0XSMam1YD5iSqtxuJZFyDN9A8dnpHZzfifWSz9/JL7i/hoytmYBJ KDVKjIGos8woIfldmPmTkSsfHka5tcJlb6SsdTnYltoI02U8dFNG6R4DJPXf5MDdJ918 HGBEP12fp2BbvwaT9PTomIGVwaJzD+9i03a4e1BG05jIm4xADEuqdFmHf+Hc9S6RPHCc ozLg==
Since you were actually only asking about the value in terms of back-porting, let me try again. There are two aspects.
1) It is mostly useful for people who build their personal Eigen version but it is less important for teams sharing a Eigen version on a network drive. People who want to use this functionality have still to adapt CMAKE_PREFIX_PATH.
2) What is definitely useful about this feature is the fact that it allows to configure pre-processor definitions. This is most valuable since by using a common configuration file, you can ensure that all you libs using Eigen use the same configurations (SIMD config, row vs. column major, etc.).
So specifically considering point 2) it might be well worth backporting this patch.
Regards,
Hauke
On Fri Dec 19 2014 at 10:46:04 AM Hauke Heibel <
hauke.heibel@xxxxxxxxx> wrote:
I added some comments. I might be able to test the changes next week - today is the last day before holidays so it's as usual quite busy.
- Hauke
On Fri Dec 19 2014 at 10:26:46 AM Gael Guennebaud <
gael.guennebaud@xxxxxxxxx> wrote:
Hi,
is there any cmake expert here who could check that the following patch is worth backporting to the 3.2 branch ?
Thank you,
Gael