| Re: [eigen] Quaternion Map Traits |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen <eigen@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [eigen] Quaternion Map Traits
- From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
- Date: Sun, 20 Jan 2013 10:26:58 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=vR5P1DrRm2UlNDGvfH7vVkvI4H2y/gCGoVUSlDbOojk=; b=NtiLCT2LyTMrDqx3u+O266ppa1lb2Jf1ArJS55vLjSZcfYJ6BmlDRrOB9UTTYEDgl+ 5GhOdhqb7bAXy0Kz5HwsE8IvQoLiEuZzyvrvmVdZxFGfvqqmecWroM0n2jwNYbbaO3t1 IyApC/iDd/uPz1IVI0lng07VOPraVuzwX0hUjVXdRRd57IOWaT83+wh1/r7s+FYl4E6B hq5Jgvfr1F+bsjFmFYMEYI2uKl5OmFQS7Y20R1bNjTMWLCnOgAoWjIJpwQYkvZ7FaJBK +tJDq/CJCa6474AiI1mT95gpnUl3bRCo8Vsb/iaBQlrZ7bGXqITwrxGD35WHRWx4kpzz gGjQ==
(sorry for the wrong manipulation, so here I go again:)
Hi,
thanks for the report, however I applied a slightly different fix:
https://bitbucket.org/eigen/eigen/commits/1da62463d511/
changeset: 1da62463d511
user: ggael
date: 2013-01-20 10:21:54
summary: Fix traits of Map<Quaternion>, and respectively extend
the unit tests
that I backported to 3.1 and 3.0.
cheers,
Gael
>
> On Fri, Jan 18, 2013 at 3:10 PM, Jean Sreng <jean.sreng@xxxxxx> wrote:
>> Hello,
>>
>> By upgrading our codebase to Eigen 3.1, we spotted a bug in the definitions
>> of Quaternion Map Traits. The Flags and Options used in these traits are
>> incorrectly referring to the Flags/Options of Quaternion Coefficients
>> instead of Map<Quaternion> Coefficients. This triggered an incorrect
>> alignment flag on functions such as multiply.
>>
>> The patch is available here (branch 3.1) but should transparently apply on
>> 3.0 and default:
>>
>> https://bitbucket.org/jsreng/eigen/commits/8b4bbc5304acf0505b297c485474b859
>>
>> I can issue a pull request if it fits your workflow better.
>>
>> Cheers,
>>
>> --
>> Jean Sreng
>>
>>