| Re: [eigen] Quaternion Map Traits |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen <eigen@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [eigen] Quaternion Map Traits
- From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
- Date: Sun, 20 Jan 2013 10:25:00 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=N+5SqFbLR5wXt4LeFdsAtNMbic5tj1+XnuP3HczP63M=; b=SphPRBiQuQf261ByxYLtBW15YMSxKzDMv5qp2kPtQ1toGBCRBXGW/2ybk8RC2PSkdf obrHfM/MC8gXZU3HDuqG2sbwu8OcODFoNCGQbL7af2SagxuLfQsqId0RjBIs6ehCLj5A ICCsbysGX5s8uhO4vbvb7tPI619/0au9KUD/GZZgGSEI8b6abgK+irRpZloXq5C9ae1g FymJ1uuAc70JQlh6MUmQNOpmwaXqXoB8nJHOsc5CiPiaTU+4l8LkYZNqsn2Q58Fj1W6A jWeWqkmA5Tcsi88zZP3Btua0b+qrjeWCpSvqEPvHfxKuK3pN8TgUT70xrOi5NKklxBuz 0/Qw==
Hi,
thanks for the report, however I applied a slightly different fix:
On Fri, Jan 18, 2013 at 3:10 PM, Jean Sreng <jean.sreng@xxxxxx> wrote:
> Hello,
>
> By upgrading our codebase to Eigen 3.1, we spotted a bug in the definitions
> of Quaternion Map Traits. The Flags and Options used in these traits are
> incorrectly referring to the Flags/Options of Quaternion Coefficients
> instead of Map<Quaternion> Coefficients. This triggered an incorrect
> alignment flag on functions such as multiply.
>
> The patch is available here (branch 3.1) but should transparently apply on
> 3.0 and default:
>
> https://bitbucket.org/jsreng/eigen/commits/8b4bbc5304acf0505b297c485474b859
>
> I can issue a pull request if it fits your workflow better.
>
> Cheers,
>
> --
> Jean Sreng
>
>