| Re: [eigen] RE: Patch for remaining min/max issues in tests |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] RE: Patch for remaining min/max issues in tests
- From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
- Date: Mon, 19 Sep 2011 15:41:09 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; bh=IizWyV4rCYO7Q58XlaX1IdhaE/hWi1Fvt6QsQ/fCfbs=; b=OoNs3QvYMiawvzyqZN6kDjX+6ltlJxEbujnIQSSNNUw8yKWy80XZyTrt/rVswUX/Bk ulBCKRfaUfGW1jW+iqkuR65AMJ6Gz3fW6KSxhgOrJ4lMVRrMLVqkg1eqwtZ3Br+xUPN4 BhARuosK57OVwHr7VbSBM7TkrfRrC4WVwZYus=
crap... I'm 100% sure I fixed them in the 3.0 branch like one or two
weeks ago... one more time I probably forgot to push or the push
failed and I closed the terminal before noticing....
gael
On Mon, Sep 19, 2011 at 2:00 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
> Thanks a lot. It seems that all this had been fixed in the default
> branch but hadn't been backported to the 3.0 branch.
>
> I'm pushing your patch as soon as unit tests finish running.
>
> Benoit
>
> 2011/9/19 Schmidt, Michael <Michael.Schmidt@xxxxxxxxxxxxxxxxxxx>:
>> As usual, I forgot to add the attachment….
>>
>>
>>
>> From: Listengine [mailto:listengine@xxxxxxxxxxxxxxxxx] On Behalf Of Schmidt,
>> Michael
>> Sent: Montag, 19. September 2011 12:00
>> To: eigen@xxxxxxxxxxxxxxxxxxx
>> Subject: [eigen] Patch for remaining min/max issues in tests
>>
>>
>>
>> Hi,
>>
>>
>>
>> even after Gaels fixes some tests failed to compile on my PC with VS2008.. I
>> have created a patch for the remaining issues. Would someone be so nice to
>> commit this to the central repository, or should I just push it?
>>
>>
>>
>> Regards, Michael
>
>
>