| Re: [eigen] Submission of two patches for Eigen 3 |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Submission of two patches for Eigen 3
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Fri, 14 Jan 2011 10:39:06 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type:content-transfer-encoding; bh=BUDYqSal52fKf7UoEhEZLdtFsTYBv8oYy7mbqTBKAoU=; b=MsZn0dbuyc8PewG2zJast+oYSRDcp8te9EQ9FCGVtRVrUhGIihp8JEcS8IFD5DUMGt fQj8Cja5LrdWHBfhEK9KGB4C7ZHcXJv7FvceAJfFnNZu95pN0cRpJafl55HZg06YKerY yk+rSRXpOlGX4uBnhhkSs/a+bv713LTRNlgrY=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=Z8FIv5TzjQTvqdypl2Po1fqMxDJlMrS9WSrUnxIpFvcB1SwIjCliPxoWmh983ISSqK u5peFiklXCz0XmuHege56R8TZx13WET9xWO6S+NoFAitSvJ7buZEmw1V0AMrrbC6jFrC Y/x3VhEmA7vCrsaMyQnBQ40uFQ1F6hv84+LBg=
You're right. Let's keep QtAlignedMalloc.
Benoit
2011/1/14 Adolfo Rodríguez Tsouroukdissian <adolfo.rodriguez@xxxxxxxxxxxxxxxxx>:
>
>
> On Fri, Jan 14, 2011 at 4:17 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
> wrote:
>>
>> By the way, I believe that the Qt alignment stuff is not needed
>> anymore as of Qt 4.7 (I talked to Thiago a while ago about it, and I
>> believe he fixed it my letting Qt use alignas()).
>
> I don't use this feature, but wouldn't this leave Qt < 4.7 users out in the
> wild?. If I was a Qt < 4.7 user, I wouldn't want to enable EIGEN2_SUPPORT
> for a feature that is more related to the Qt version than to the Eigen
> version. Or am I missing the point?.
>
> Adolfo.
>
>>
>> Is it time to kill QtAlignedMalloc (move it to EIGEN2_SUPPORT) ?
>>
>> Benoit
>>
>> 2011/1/14 Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>:
>> > I dont know for the source-dir-scoping.
>> >
>> > But indeed, Qt stuff was broken. I've committed a slightly different
>> > fix.
>> >
>> > Thomas
>> >
>> > --
>> >
>> > Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>
>> >
>> > http://www.freehackers.org/thomas
>> >
>> > On Thursday 13 January 2011 19:39:10 hamelin.philippe@xxxxxxx wrote:
>> >
>> >> Hello,
>> >
>> >>
>> >
>> >> it would be great if these two patches could be applied on the master
>> >> branch of Eigen 3:
>> >
>> >>
>> >
>> >> 1. fix-cmake-qt-tests.patch : Fix compilation error of tests when Qt4
>> >> is
>> >> found.
>> >
>> >>
>> >
>> >> 2. project-source-dir-scoping.patch : Replace CMAKE_SOURCE_DIR with
>> >> PROJECT_SOURCE_DIR to allow the cmake project to be included by a root
>> >> project.
>> >
>> >>
>> >
>> >> Thank you,
>> >
>> >>
>> >
>> >> ------------------------------------
>> >
>> >> Philippe Hamelin, ing. jr, M. Ing
>> >
>> >> Chercheur / Researcher
>> >
>> >>
>> >
>> >> T: 450-652-8499 x2198
>> >
>> >> F: 450-652-1316
>> >
>> >>
>> >
>> >> Expertise robotique et civil
>> >
>> >> Institut de recherche d'Hydro-Québec (IREQ)
>> >
>> >> 1740, boul. Lionel-Boulet
>> >
>> >> Varennes (QC) J3X 1S1, Canada
>> >
>> >>
>> >
>> >>
>> >
>> >>
>>
>>
>
>
>
> --
> Adolfo Rodríguez Tsouroukdissian, Ph. D.
>
> Robotics engineer
> PAL ROBOTICS S.L
> http://www.pal-robotics.com
> Tel. +34.93.414.53.47
> Fax.+34.93.209.11.09
>
> CONFIDENTIALITY NOTICE: This e-mail and the accompanying document(s) may
> contain confidential information which is privileged and intended only for
> the individual or entity to whom they are addressed. If you are not the
> intended recipient, you are hereby notified that any disclosure, copying,
> distribution or use of this e-mail and/or accompanying document(s) is
> strictly prohibited. If you have received this e-mail in error, please
> immediately notify the sender at the above e-mail address.
>