On Fri, Jan 14, 2011 at 4:17 PM, Benoit Jacob
<jacob.benoit.1@xxxxxxxxx> wrote:
By the way, I believe that the Qt alignment stuff is not needed
anymore as of Qt 4.7 (I talked to Thiago a while ago about it, and I
believe he fixed it my letting Qt use alignas()).
I don't use this feature, but wouldn't this leave Qt < 4.7 users out in the wild?. If I was a Qt < 4.7 user, I wouldn't want to enable EIGEN2_SUPPORT for a feature that is more related to the Qt version than to the Eigen version. Or am I missing the point?.
Adolfo.
Is it time to kill QtAlignedMalloc (move it to EIGEN2_SUPPORT) ?
Benoit
2011/1/14 Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>:
> I dont know for the source-dir-scoping.
>
> But indeed, Qt stuff was broken. I've committed a slightly different fix.
>
> Thomas
>
> --
>
> Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>
>
> http://www.freehackers.org/thomas
>
> On Thursday 13 January 2011 19:39:10 hamelin.philippe@xxxxxxx wrote:
>
>> Hello,
>
>>
>
>> it would be great if these two patches could be applied on the master
>> branch of Eigen 3:
>
>>
>
>> 1. fix-cmake-qt-tests.patch : Fix compilation error of tests when Qt4 is
>> found.
>
>>
>
>> 2. project-source-dir-scoping.patch : Replace CMAKE_SOURCE_DIR with
>> PROJECT_SOURCE_DIR to allow the cmake project to be included by a root
>> project.
>
>>
>
>> Thank you,
>
>>
>
>> ------------------------------------
>
>> Philippe Hamelin, ing. jr, M. Ing
>
>> Chercheur / Researcher
>
>>
>
>> T: 450-652-8499 x2198
>
>> F: 450-652-1316
>
>>
>
>> Expertise robotique et civil
>
>> Institut de recherche d'Hydro-Québec (IREQ)
>
>> 1740, boul. Lionel-Boulet
>
>> Varennes (QC) J3X 1S1, Canada
>
>>
>
>>
>
>>