| Re: [eigen] Submission of two patches for Eigen 3 |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Submission of two patches for Eigen 3
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Fri, 14 Jan 2011 10:17:31 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type:content-transfer-encoding; bh=YjaCRlG1EMw693+6Q/U7WYcSivouENSm/vaJgB3aufs=; b=O0+VCKe6+UfKL7jq1IdydkqPiZJU9UHuYYoD9CiprxxgB4oiNrnibZA7E2t7EtH0tZ Pix7gJNdOUqDDju3VxAh2O6FS2ZL3jWRr72Pbl5GqBt2d+CoTE7SktLvJaRl640IZRYt buo37D60AuGMeYWfZONvRPcGM7+ujU7A1fmXA=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=sszLI1e87w+2w3dQ4qxNUYRk/nI4gik+BDsC6k5OlKtQYNAi+ZuBwWaVRlwbNNwwLn 25iE0L7DLfgkXS6hb7slchhjUBdEQtpFawbmbNPz7fipXcjObNjgFW2MLYOV2fHt3D5V jVgjb8h4R/wRHkzCH81zr6Y5fIhcwGMVw7bTw=
By the way, I believe that the Qt alignment stuff is not needed
anymore as of Qt 4.7 (I talked to Thiago a while ago about it, and I
believe he fixed it my letting Qt use alignas()).
Is it time to kill QtAlignedMalloc (move it to EIGEN2_SUPPORT) ?
Benoit
2011/1/14 Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>:
> I dont know for the source-dir-scoping.
>
> But indeed, Qt stuff was broken. I've committed a slightly different fix.
>
> Thomas
>
> --
>
> Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>
>
> http://www.freehackers.org/thomas
>
> On Thursday 13 January 2011 19:39:10 hamelin.philippe@xxxxxxx wrote:
>
>> Hello,
>
>>
>
>> it would be great if these two patches could be applied on the master
>> branch of Eigen 3:
>
>>
>
>> 1. fix-cmake-qt-tests.patch : Fix compilation error of tests when Qt4 is
>> found.
>
>>
>
>> 2. project-source-dir-scoping.patch : Replace CMAKE_SOURCE_DIR with
>> PROJECT_SOURCE_DIR to allow the cmake project to be included by a root
>> project.
>
>>
>
>> Thank you,
>
>>
>
>> ------------------------------------
>
>> Philippe Hamelin, ing. jr, M. Ing
>
>> Chercheur / Researcher
>
>>
>
>> T: 450-652-8499 x2198
>
>> F: 450-652-1316
>
>>
>
>> Expertise robotique et civil
>
>> Institut de recherche d'Hydro-Québec (IREQ)
>
>> 1740, boul. Lionel-Boulet
>
>> Varennes (QC) J3X 1S1, Canada
>
>>
>
>>
>
>>