| Re: [eigen] Eigen binary I/O proposal |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Eigen binary I/O proposal
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Tue, 7 Jul 2009 05:59:21 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=3GQaaipfu7TnzFs4CUinGRmJKfXKiyajyjaGEg45B08=; b=eWzx+JNdcO1Mw3uHHF4Ahf0hZJuEL27w5ZohArNjjAXheo8BAauBN9+MCMsqX98m3a MTJWd8XtZ6sI335cFiqI71I7mS2J+xIzazZ0UgfLThvi4HRgKocjKd99Ar7mx/D4fbj2 8g7mbqbmQ5YdIOiJp/uJaAfTG9B3MXroTga4Q=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=Yj5J2+LK/WsJAwAqVmP8ch46FZo2Lm9ODMWDtBPzYQr+QTBbSLoYxOFBmP72rMzvCZ VRVLmoXCf3IZzG+QwDutS3AoqhfYr2pR1OHq2igHdW+YoZOl+noRIMFscq9XI/MFb4QB hSt6JSkw7vUmHBYL3cdfWhgBGptEnm8XrkKOg=
Hi,
had a very quick look at the code, 2 things come to mind:
1) make sure endianness issues are taken care of
2) why use plain C stuff like printf, maybe use c++ streams instead.
if you allow the user to use your functions on custom stream types,
that's more powerful.
Benoit
2009/7/7 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>:
> Hi,
>
> I'm going to be offline for rougly 4 days starting now, can't look at
> code now, but if you want to code a new eigen feature the best way you
> can propose it is by cloning the eigen2 repository at bitbucket and
> adding the feature in your repo. Makes it easy for people to start
> using your feature, send you patches, generate diffs, etc.
>
> Benoit
>
> 2009/7/7 Rohit Garg <rpg.314@xxxxxxxxx>:
>> Hi,
>>
>> First things first.
>>
>> http://sites.google.com/site/rpg314/Home/eigen-proposal
>>
>> This is a battle-tested, well commented (I think) piece of code along
>> with unit tests. The largest file I used it with was 1.2 GB.
>>
>> There has been some demand for serialization of Eigen objects here
>>
>> http://forum.kde.org/viewtopic.php?f=74&t=61960.
>>
>> So I think this may fit the bill. There could be a lot of scope for
>> template tricks to beautify the API, but for my needs, I could manage
>> to to work with raw C too. I have tested it on Linux 32 bit with gcc
>> 3.4 and linux 64 bit, (both gcc 4.3 and gcc 4.4) respectively.
>>
>> Comments/questions/cribs/suggestions/flames/rants/commendations(!) welcome.
>>
>> Cheers,
>>
>> --
>> Rohit Garg
>>
>> http://rpg-314.blogspot.com/
>>
>> Senior Undergraduate
>> Department of Physics
>> Indian Institute of Technology
>> Bombay
>>
>>
>>
>