| Re: [eigen] Add placement delete to match placement new |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Add placement delete to match placement new
- From: Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>
- Date: Mon, 27 Jul 2009 11:19:11 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=03uapNLmtw24uohRGeCAcIMlne0RUfxOVNp61OFG3Ak=; b=WHF36YqSPVF/WfVyNQR0lxiR+qK1Td/Cl2vqrslkNGUGSX2ukJkP15VCEMt2WuH8th JbjhMmjDpRQMB38QG4G8QrEfmzhamB64IJ8aZDF2J8/e35aU/bqQFgtA07pKmFetxPSN Xuht2RWCPQZOmJjI9IhX+ZZxf2C1+2wtpQFr4=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=NwP5gdZEeQAZG0WDW0c9cpz02Vfsgzm4PkMCIZNzdPQRB+RA5ArD8Enu18dZQoViIY qfFf4YgG4E3KNFKexsmNTyRMknvp0UhUej8PDFfjNmh6Uz1qpiSgH1VCadlZyYmfpTuo aoa0wPUntVNS1/L3vFZ2M5ElM9cSwHBh4Fulw=
Somehow I failed to apply the patch.
I did the following...
hg up 2.0
hg qimport diff
cd .hg/patches
hg qpush diff
and got this output.
(working directory not at tip)
applying mem.diff
patching file Eigen/src/Core/util/Memory.h
Hunk #1 FAILED at 238
1 out of 1 hunks FAILED -- saving rejects to file
Eigen/src/Core/util/Memory.h.rej
patch failed to apply
calling hook pretxncommit.crlf: hgext.win32text.forbidcrlf
patch failed, rejects left in working dir
errors during apply, please fix and refresh mem.diff
No clue, what I am doing wrong and the patch seems to be ok. So right
now, I cannot run the tests...
On Mon, Jul 27, 2009 at 10:28 AM, Benoit Jacob<jacob.benoit.1@xxxxxxxxx> wrote:
> Indeed, Hauke fixed this on May 7, along with many other issues.
>
> Somehow this wasn't backported, and I don't remember anymore if there
> was a good reason not to.
>
> I merged this changeset to the 2.0 branch, it seems to work, attached
> is the resulting patch. I can't test at the moment, but if tests work
> I see no reason not to backport?
>
> Benoit