Re: [eigen] Add placement delete to match placement new

[Benoit Jacob <jacob.benoit.1@xxxxxxxxx>]

Indeed, Hauke fixed this on May 7, along with many other issues.

Somehow this wasn't backported, and I don't remember anymore if there
was a good reason not to.

I merged this changeset to the 2.0 branch, it seems to work, attached
is the resulting patch. I can't test at the moment, but if tests work
I see no reason not to backport?

Benoit

2009/7/27 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
> Hi Keir,
>
> you are in the 2.0 branch right? In the devel version it is already
> fixed. Probably Gael and/or Benoit prefer a backport of the version
> and we should wait for their comment.
>
> Regards,
> Hauke
>
> On Mon, Jul 27, 2009 at 2:52 AM, Keir Mierle<mierle@xxxxxxxxx> wrote:
>> Eigen is missing to a placement delete operator to match its placement new.
>> I only noticed this using MS's cl.exe, which complained about this.
>> Apparently it's a problem with exceptions enabled. If someone with access
>> can to commit this, that would be great.
>> Keir
>> libmv note: see r598 and r612 changes to third_party/
>
>
>

Attachment: diff
Description: Binary data