Re: [eigen] Statistics module

[ Thread Index | Date Index | More Archives ]


thanks for your comment.

1) How can I put it in unsupported, if MatrixBase and PartialRedux
need to be extended? Using EIGEN_MATRIXBASE_PLUGIN?
2) Do you know where to find some information on how to perform unit
tests with MSVC?


2009/5/7 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>:
> Hi,
> Thanks for your patch. It looks very good. Just a few remarks:
> 0) no need to zip your patch, it's more convenient not zipped
> 1) If we create a new module, it should go into unsupported/ at first,
> until it has enough users (at least potential users)
> and the API has been tested enough. So in your case,
> unsupported/Eigen/Statistics.
> 2) A unit-test would be very useful (see unsupported/test/)
> 3) don't forget to add/update the CMakeLists.txt
> 4) also add the standard licence header at the beginning of every
> file, with copyright yourself
> Cheers,
> Benoit
> 2009/5/5 Márton Danóczy <marton78@xxxxxxxxx>:
>> Dear developers of Eigen,
>> I have started to write a statistics module for Eigen, attached you'll
>> find a patch. So far I have only implemented the modules I needed
>> (mean, variance and logsumexp), but the list will be growing.
>> I would be grateful for any comments,
>> Marton

Mail converted by MHonArc 2.6.19+