| Re: [eigen] Statistics module |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Statistics module
- From: Márton Danóczy <marton78@xxxxxxxxx>
- Date: Thu, 7 May 2009 18:38:06 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=cLk4acYqY3aUCeG5r5sA0TQRkQHbe/IXNqOPDI+prsc=; b=EVd19x+t5BcemhmcP1OGjGEMkFjHLuW/8T8NvfNsedqBK5UdwrptlO/4ImN9CfP0Fk cmEq0nrsXtbFDumGu1hjNQOqNbMfYnhF5meQcyVFi2DjSJo1Upw+6a2YWoFjoe0B5euO 4I32+Yjd4qCPknnnwpZVjsB/Qukqd56mEdxkY=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; b=GFfopCufZJRJnTllntiUmxld2CuEqbVyc3O2GkNHXRfiQyqz8pGDgAH/goUdz7nhkW yHNxOdEdueeDcCVJw/H6gocIggjeV8B96Z9v/qYL8medK1n3ynsZj2pftFvELthfuGq3 UPxcvmfgzvCVag9XZXiZunBv82DA++RJgoAoU=
Hi,
thanks for your comment.
1) How can I put it in unsupported, if MatrixBase and PartialRedux
need to be extended? Using EIGEN_MATRIXBASE_PLUGIN?
2) Do you know where to find some information on how to perform unit
tests with MSVC?
Marton
2009/5/7 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>:
> Hi,
>
> Thanks for your patch. It looks very good. Just a few remarks:
> 0) no need to zip your patch, it's more convenient not zipped
> 1) If we create a new module, it should go into unsupported/ at first,
> until it has enough users (at least potential users)
> and the API has been tested enough. So in your case,
> unsupported/Eigen/Statistics.
> 2) A unit-test would be very useful (see unsupported/test/)
> 3) don't forget to add/update the CMakeLists.txt
> 4) also add the standard licence header at the beginning of every
> file, with copyright yourself
>
> Cheers,
> Benoit
>
> 2009/5/5 Márton Danóczy <marton78@xxxxxxxxx>:
>> Dear developers of Eigen,
>>
>> I have started to write a statistics module for Eigen, attached you'll
>> find a patch. So far I have only implemented the modules I needed
>> (mean, variance and logsumexp), but the list will be growing.
>>
>> I would be grateful for any comments,
>> Marton
>>
>
>
>