| Re: [eigen] Statistics module |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Statistics module
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Thu, 7 May 2009 18:33:03 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=Uh5p2V8myS/tTzv/nvxuiqawB7C8Py6cBsXxc2O5tzY=; b=VZyWJvj3U7sdyrcl1G4eHJgdbJ80HxRvsJA+sCVSXIxACSdxODdKJ/qsR7qPLDwkPe iqnkwcvPIML+9RrGbZN6O2isU9fQ+ACah5gBZ7tlXJ9dTKKgSu0HZnPmsT6LbJyeSQKe sZmjEJckjPAGQBPdSQdVGkTtc1SLUP+4PAVG8=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=a3IMkOHRSHwgirwoolGpXqfWfjn5JnLEzfEV2q0c5nYF+pkmBgY0XOTf6Ey18oBrpy piAcdCKzcqZXilJZitI6c6ZcYWTneK4vUl7ulfDOqOeR7bxRrIRerCF/Hv8XOlREdIxp ItMthsxjHkJCXyVyWg2QqmdTBtoBOAkfKEsE8=
Hi,
Thanks for your patch. It looks very good. Just a few remarks:
0) no need to zip your patch, it's more convenient not zipped
1) If we create a new module, it should go into unsupported/ at first,
until it has enough users (at least potential users)
and the API has been tested enough. So in your case,
unsupported/Eigen/Statistics.
2) A unit-test would be very useful (see unsupported/test/)
3) don't forget to add/update the CMakeLists.txt
4) also add the standard licence header at the beginning of every
file, with copyright yourself
Cheers,
Benoit
2009/5/5 Márton Danóczy <marton78@xxxxxxxxx>:
> Dear developers of Eigen,
>
> I have started to write a statistics module for Eigen, attached you'll
> find a patch. So far I have only implemented the modules I needed
> (mean, variance and logsumexp), but the list will be growing.
>
> I would be grateful for any comments,
> Marton
>