Re: [eigen] [PATCH] Block traits patch

[Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>]

Hi Benoit,

I already forgot that I was working on the branch - sorry for the confusion. After switching back to the trunk I realized that the patch was not complete - CoeffReadCost was missing. I just attached the new patch as well as a patch for the MathFunctions.h - in that one I fixed the double-float conversions in the defines - the 800+ warnings were a little bit annoying.

Almost all unit tests passed. Only test_qtvector failed - probably due to the missing delete operator corresponding to the overridden new operator (I got a warning C4291) and test_BVH as well as test_autodiff did not compile. The first one because StdVector does not work on Visual Studio 2008 (I don't have more details at the moment) and the second one because of some the 'asm' lines and some other calls in test_autodiff().

hth,
Hauke

On Thu, Apr 9, 2009 at 2:08 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:

Hi,

Thanks for the patch: I applied it to both the branch and the trunk.

It was actually a patch against the stable branch -- took me a while
to figure why it didn't apply to trunk!

Cheers,
Benoit


2009/4/9 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:

> Hi there,
>
> the patch explicitly resolves nested traits instead of passing the request
> to MatrixType.
>
> Should normally not be required but this thread
> (http://forum.kde.org/nested-block-in-plugin-unit-t-41342.html) contains an
> example that does not compile (vs9) without the patch.
>
> Kind regards,
> Hauke
>

Attachment: Block.patch
Description: Binary data

Attachment: MathFunctions.patch
Description: Binary data