| Re: [eigen] Code review for .resizeLike() |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Code review for .resizeLike()
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Mon, 2 Feb 2009 19:33:56 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=uN/oDXry64Ztb94sdbVNU486Zaj9qQnHXQWCyHMLYvk=; b=p9QGkmGe2G4Qwb/OUVnQ3QtZxHp7N2fVZ7Gilu3AEVu8YBAwdj927Wg2BbNYPydGMZ msjAtbanQOGW3Ejz3H+IRTTftm3+Cim74LgH4g5JScCDsnnYXuZkyQzOolpKKBcBQcW+ 33LFEQEnK5QUNJmMKIY0A5u/rD3XxhI+b1gsg=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=MA8MOejLlb6wpRBanLdhD77J+qnY5Jn4lfMJ0UCsl+77jOsx6FqND5C1WDu6JUbIMJ gQNSWhOyf+zYZ6ekFzCVP4f0HeunA8bk8IWbWDQyc6hSEEd6p2yLLZqapQjnOW3hYpMn 6p5Gf9gZZysjbBOgkVwknTPIgz0PUJJPnqRvs=
2009/2/2 Keir Mierle <mierle@xxxxxxxxx>:
> http://codereview.appspot.com/12869/show
>
> Please comment on this patch (or apply it). I'll make any necessary changes
> and re-upload.
Hi,
I would suggest that you avoid calling other.isVector(), if you really
want to allow passing it objects from other libraries.
isVector() is just: rows() == 1 || cols() == 1
Cheers,
Benoit