Re: [eigen] Code review for .resizeLike()

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]


2009/2/2 Keir Mierle <mierle@xxxxxxxxx>:
> http://codereview.appspot.com/12869/show
>
> Please comment on this patch (or apply it). I'll make any necessary changes
> and re-upload.

Hi,

I would suggest that you avoid calling other.isVector(), if you really
want to allow passing it objects from other libraries.
isVector() is just: rows() == 1 || cols() == 1

Cheers,
Benoit



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/