| Re: [eigen] Bug in traspose |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Bug in traspose
- From: "Schleimer, Ben" <bensch128@xxxxxxxxx>
- Date: Tue, 15 Jan 2008 19:40:19 -0800 (PST)
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; b=k1pwgdoX/9xzAhc8c3T2ccoGeOPYbLZ1SUaLZ1NKUk7ch8tNgV79F3FA1LLsjTeD762YhKZQxDvcZWxTpe8s7Qa79XZ6pjrSJLoyI9FzuZ1HRn+zcc/x/XA0jN5Bvl44hC3bFxzx6phGbhZvpb7Vh35SwtP0KwThtszQY+lhzIc=;
Hi,
> The fact that my unit-tests did not catch this bug is interesting (I can see
> the reason). I will keep that in mind for the next round of unit-tests
> improvements (alpha4?). I am also thinking that QTestLib is not very good for
> us, actually I am already bypassing large parts of it in the main() function,
> so we might get rid of it.
I wanted to add that this bug is a perfect chance to demonstrate why unit tests are *a really good
idea*.
Implement a test which fails because of this bug and then change the code to make the test pass.
Then you'll have the bug squished forever. Dont just fix the bug and then don't update your unit
tests. Switching to a different testing framework is not so important.
Cheers
Ben
>
> Cheers,
>
> Benoit
>
>
> On Tuesday 15 January 2008 00:27:09 ollupaC De La Pradera wrote:
> > Hello,
> >
> > I think there's a bug in Transpose.h, at least in current svn revision
> > (761491):
> > enum {
> > RowsAtCompileTime = MatrixType::Traits::ColsAtCompileTime,
> > ColsAtCompileTime = MatrixType::Traits::RowsAtCompileTime,
> > MaxRowsAtCompileTime = MatrixType::Traits::MaxRowsAtCompileTime,
> > MaxColsAtCompileTime = MatrixType::Traits::MaxColsAtCompileTime
> > };
> > should be:
> > enum {
> > RowsAtCompileTime = MatrixType::Traits::ColsAtCompileTime,
> > ColsAtCompileTime = MatrixType::Traits::RowsAtCompileTime,
> > MaxRowsAtCompileTime = MatrixType::Traits::MaxColsAtCompileTime,
> > MaxColsAtCompileTime = MatrixType::Traits::MaxRowsAtCompileTime
> > };
> >
> > It's being more difficult that what I initially thought to refresh my
> > algebra and numerical methods while trying to understand all that complex
> > templates stuff, but I'm still here working even if I don't show up a lot.
> >
> > By the way, I'm not sure if I have to post it here, or to some bugzilla, or
> > just send it to Jacob?
> >
> > Cheers
> >
> > Ramon
>
>
>