Re: [AD] Allegro 4.4 resize window support

Hi Tobias,

On Tue, Aug 5, 2014 at 1:16 PM, Tobias Hansen <thansen@xxxxxxxxxxxxxxxx> wrote:

Hi David,

sorry I'm joining the discussion so late. I hope we can somehow manage
to get that new Allgro 4 version with your patch out.

Don't worry about the late reply, I didn't get enough time to test and complete the patch for all platforms anyway.

That function change_window_state you're talking about would allow
minimizing/maximizing etc. from within the program instead of using the
buttons on the window border right? Sounds fine to me. Are you still
willing to add that?

Yes, it's called get/set_window_state() with a value that can be AL_FULLSCREEN_WINDOW/AL_MINIMIZED_WINDOW/AL_MAXIMIZED_WINDOW. Anyway I don't use them on Aseprite and it adds some complexity that I wasn't able to test.

Also, Peter mentioned "There's no need for the bitfields in
RESIZE_DISPLAY_EVENT, so drop them."

I guess he means is_maximized and is_restored. Do you use them in aseprite?

I use is_maximized in aseprite to save the old/original/restored size of the window when the event is received (when the window is maximized, I save the original window size to restore it when the program is reopened).

Anyway, I'm not quite sure if I'll be able to dedicate more time to the patch, so I'm attaching it here. It's a work in progress, but maybe someone want to continue with it or help/comment with some testing.

Best regards

- David

Cheers,
Tobias

On 11/18/2013 03:56 AM, David Capello wrote:
> New version, now compiled/tested on X11.
>
>
> On Sun, Nov 17, 2013 at 10:56 PM, David Capello <davidcapello@xxxxxxxxxx>wrote:
>
>> This is WIP, I wasn't able to test it on Linux nor Mac OS X yet.
>> You can start looking at it and tell me what you think about it
>> (there is a exresize.c example, I've tested on Win8 and it's working ok).
>>
>> Also I'd like to add a function to change the window state (maximize,
>> restore,
>> minimize, windowed-fullscreen/F11). Maybe:
>>
>> void change_window_state(int state);
>>
>> where state = AL_MINIMIZE, AL_MAXIMIZE, AL_RESTORE, AL_WIN_FULLSCREEN
>>
>> What do you think?
>>
>>
>>
>>
>> On Sun, Nov 17, 2013 at 11:14 AM, David Capello <davidcapello@xxxxxxxxxx>wrote:
>>
>>> On Sat, Nov 16, 2013 at 7:47 PM, Peter Wang <novalazy@xxxxxxxxxx> wrote:
>>>
>>>> On Sat, 16 Nov 2013 15:46:08 -0200, David Capello <
>>>> davidcapello@xxxxxxxxxx> wrote:
>>>>> If you people tell me that we can release another Allegro 4 version,
>>>> then
>>>>> I'll prepare the patch and send it to the list.
>>>>
>>>> For you, David. If you do all the work :)
>>>>
>>>
>>> haha it's fair enough :) I'll try to test on Win8.1, Win7, WinXP, Ubuntu,
>>> and a Mac OS X (with luck).
>>> Anyway I'd love to see more people trying to compile the patch.
>>>
>>> I'll continue from the last commit in 4.4 branch in git repo (
>>> b995d534131a4024b99ca6a84d6fb513f00d9783 )
>>>
>>> https://sourceforge.net/p/alleg/allegro/ci/b995d534131a4024b99ca6a84d6fb513f00d9783
>>>
>>> Then I'll send the patch ASAP to the list so we can discuss it (API,
>>> function names, etc.).
>>>
>>> See you soon people
>>>
>>>
>>
>
>
>

> ------------------------------------------------------------------------------
> DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
> OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
> Free app hosting. Or install the open source package on any LAMP server.
> Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
> http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
>
>
>