[AD] Allegro in Debian

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


Hi,

there are some news on Allegro in Debian. Allegro 4.4 made it into
Debian and will be in the next Debian and Ubuntu releases. We have not
found a sponsor (a Debian Developer who uploads the package) for Allegro
5 yet.

I have some more patches for you. This one fixes some spelling mistakes
in the Allegro 5 documentation:

http://anonscm.debian.org/gitweb/?p=pkg-games/allegro5.git;a=blob;f=debian/patches/fix-manpages.patch;hb=HEAD

And here are the patches that are currently applied to Allegro 4.4:

http://anonscm.debian.org/gitweb/?p=pkg-games/allegro4.4.git;a=tree;f=debian/patches;hb=HEAD

Please include as many as possible. If you have comments, they are also
welcome. Some patches are from the old Allegro 4.2 package and we were
not exactly sure if everything was still needed.

Four Allegro 5 tests are failing in a i386 chroot on a amd64 host (with
--no-display). Can someone test if this happens generally on i386?

FAIL test hl thick-50 [sw] - hash=62819701
FAIL test hl thick-50 clip [sw] - hash=a601764e
FAIL test hl nolight [sw] - hash=9889e6b5
FAIL test hl nolight clip [sw] - hash=85600dc7

The file examples/ex_joystick_hotplugging.c has the executable flag set.
Would you fix that for the next release?


And some comments from Debian Developer Paul Wise, who reviewed the
Allegro 5 package and might sponsor it when he is satisfied:

Am 04.07.2012 00:59, schrieb Paul Wise:
>
> addons/acodec/ogg.c and addons/acodec/flac.c has a copyright holder,
> but no license, I guess it is zlib?
>
> Many of the source files reference readme.txt instead of LICENSE.txt.
>
> You might want to point upstream at this blog post:
>
>
http://tieguy.org/blog/2012/03/17/on-the-importance-of-per-file-license-information/
>
> Embedded copies of (parts) of other projects:
>
> docs/tools/trex.*: http://tiny-rex.sourceforge.net/
> docs/src/autosuggest.js:
> http://www.codeproject.com/KB/scripting/AutoSuggestControl.aspx
> bstrlib.*: http://bstring.sourceforge.net/
> examples/data/DejaVuSans*: http://dejavu-fonts.org/
>
> There are some generated files that should probably be removed from
> the upstream tarball and created at build time instead. At the very
> least the build system should automatically recreate them if they are
> missing and the Debian package should remove them before starting the
> build.
>
> src/scanline_drawers.c src/convert.c
> include/allegro5/opengl/GLext/*gl*_ext_alias.h
> include/allegro5/internal/aintern_convert.h docs/man/ docs/html/
> docs/src/refman/images/*.png
>
> Some of the stuff looks like it might be missing source. In particular:
>
> addons/primitives/directx_shaders.c: contains precompiled shaders
>
> allegro.pcx: some sort of 3D scene, I guess it is not meant to be
> modified, but if it is then it is missing a rendering script, a font
> and the models/textures for the rest of the scene.
>
> fakeamp.tga *font.tga green.tga: have some pre-rendered text in them,
> some of which look like they are vector fonts, might be missing the
> font(s) and a script to render them.
>
> mysha.tga and mysha256x256.png are modified versions of mysha.pcx, I
> guess these can't be built automatically though.
>
> examples/data/DejaVuSans.ttf: the source for the DejaVu font(s) are
> some fontforge files.
>
> examples/data/haiku/*.png: look like some of them might have been
> produced in a vector image program.
>
> examples/data/haiku/*.ogg: source for these are .wav files and are in
> the tarball linked from here:
>
> http://www.allegro.cc/forums/thread/602636/844773
>
> demos/a5teroids/data/sfx/game_music.ogg: sounds like it was made from
> something else.
>
> cppcheck warnings:
>
> [examples/ex_acodec_multi.c:53]: (error) Memory leak: sample_data
> [examples/ex_acodec_multi.c:46]: (error) Memory leak: sample
> [examples/ex_blend2.cpp:110]: (error) Array 'rgba_label[2]' accessed
> at index 2, which is out of bounds
> [examples/ex_drawpixels.c:75]: (error) Buffer access out-of-bounds: stars
> [misc/msvchelp.c:43]: (error) Resource leak: fout
> [misc/vcvars.c:138]: (error) Buffer overrun possible for long cmd-line
args
> [src/display.c:388]: (error) Possible null pointer dereference:
> display - otherwise it is redundant to check if display is null at
> line 392
>
> pyflakes warnings:
>
> python/generate_python_ctypes.py:2: 'os' imported but unused
> python/generate_python_ctypes.py:3: 'from ctypes import *' used;
> unable to detect undefined names
> python/generate_python_ctypes.py:314: local variable 'release' is
> assigned to but never used
> python/generate_python_ctypes.py:315: local variable 'version' is
> assigned to but never used
> python/checkdocs.py:19: undefined name 'options'
> python/checkdocs.py:34: undefined name 'options'
> python/checkdocs.py:88: undefined name 'options'
> python/checkdocs.py:90: undefined name 'options'
> python/checkdocs.py:167: undefined name 'options'
> python/checkdocs.py:168: undefined name 'options'
> python/checkdocs.py:173: undefined name 'options'
> python/checkdocs.py:185: undefined name 'options'
> python/checkdocs.py:190: local variable 'n' is assigned to but never used
> python/ex_draw_bitmap.py:3: 'glob' imported but unused
> python/ex_draw_bitmap.py:4: 'from random import *' used; unable to
> detect undefined names
> python/ex_draw_bitmap.py:5: 'from math import *' used; unable to
> detect undefined names
> python/ex_draw_bitmap.py:6: 'from ctypes import *' used; unable to
> detect undefined names
> python/ex_draw_bitmap.py:11: 'from allegro import *' used; unable to
> detect undefined names
> misc/make_converters.py:179: unexpected indent
>                 if (shift > 0):
>                 ^
> misc/make_scanline_drawers.py:217: undefined name 'texture'
> misc/make_scanline_drawers.py:257: undefined name 'texture'
> misc/make_scanline_drawers.py:261: undefined name 'opaque'
> misc/make_scanline_drawers.py:261: undefined name 'white'
> misc/make_scanline_drawers.py:266: undefined name 'texture'
> misc/make_scanline_drawers.py:274: undefined name 'opaque'
> misc/make_scanline_drawers.py:330: undefined name 'texture'
> misc/make_scanline_drawers.py:348: local variable 'vv_ofs' is assigned
> to but never used
> misc/make_scanline_drawers.py:348: local variable 'uu_ofs' is assigned
> to but never used
> misc/make_scanline_drawers.py:352: undefined name 'texture'
> misc/make_scanline_drawers.py:372: undefined name 'grad'
> misc/make_scanline_drawers.py:376: undefined name 'white'
> misc/make_scanline_drawers.py:401: undefined name 'shade'
> misc/make_scanline_drawers.py:419: undefined name 'texture'
> misc/make_scanline_drawers.py:438: undefined name 'grad'
>
> gcc warnings:
>
> In file included from src/tri_soft.c:23:0:
> include/allegro5/internal/aintern_blend.h:43:6: warning: always_inline
> function might not be inlinable [-Wattributes]
> In file included from src/tri_soft.c:23:0:
> include/allegro5/internal/aintern_blend.h:29:1: warning: always_inline
> function might not be inlinable [-Wattributes]
>
> src/x/xkeyboard.c: In function '_al_xwin_get_keyboard_mapping':
> src/x/xkeyboard.c:606:10: warning: 'XKeycodeToKeysym' is deprecated
> (declared at /usr/include/X11/Xlib.h:1695) [-Wdeprecated-declarations]
>
> src/x/xrandr.c: In function 'xrandr_realign_crtc_origin':
> src/x/xrandr.c:457:10: warning: variable 'ret' set but not used
> [-Wunused-but-set-variable]
>
> src/opengl/ogl_bitmap.c: In function 'ogl_unlock_region':
> src/opengl/ogl_bitmap.c:813:8: warning: variable 'orig_format' set but
> not used [-Wunused-but-set-variable]
>
> addons/primitives/line_soft.c: In function 'line_stepper':
> addons/primitives/line_soft.c:412:19: warning: variable 'minor' set
> but not used [-Wunused-but-set-variable]
> addons/primitives/line_soft.c:430:19: warning: variable 'minor' set
> but not used [-Wunused-but-set-variable]
> addons/primitives/line_soft.c:449:19: warning: variable 'minor' set
> but not used [-Wunused-but-set-variable]
> addons/primitives/line_soft.c:474:19: warning: variable 'minor' set
> but not used [-Wunused-but-set-variable]
>
> addons/image/png.c: In function 'really_load_png':
> addons/image/png.c:100:8: warning: variable 'tRNS_to_alpha' set but
> not used [-Wunused-but-set-variable]
> addons/image/png.c: In function '_al_save_png_f':
> addons/image/png.c:434:8: warning: variable 'depth' set but not used
> [-Wunused-but-set-variable]
>
> examples/ex_blend.c: In function 'draw':
> examples/ex_blend.c:104:18: warning: variable 'white' set but not used
> [-Wunused-but-set-variable]
>
> examples/ex_blend2.cpp: In member function 'void
Prog::blending_test(bool)':
> examples/ex_blend2.cpp:251:18: warning: variable 'opaque_white' set
> but not used [-Wunused-but-set-variable]
>
> examples/ex_blit.c: In function 'example_bitmap':
> examples/ex_blit.c:31:27: warning: variable 'lock' set but not used
> [-Wunused-but-set-variable]
>
> examples/ex_clip.c: In function 'example_bitmap':
> examples/ex_clip.c:33:27: warning: variable 'lock' set but not used
> [-Wunused-but-set-variable]
>
> examples/ex_display_options.c: In function 'main':
> examples/ex_display_options.c:194:8: warning: variable 'n' set but not
> used [-Wunused-but-set-variable]
>
> examples/ex_drawpixels.c: In function 'main':
> examples/ex_drawpixels.c:30:27: warning: variable 'lr' set but not
> used [-Wunused-but-set-variable]
>
> examples/ex_logo.c: In function 'generate_logo':
> examples/ex_logo.c:77:35: warning: variable 'lock2' set but not used
> [-Wunused-but-set-variable]
> examples/ex_logo.c:77:27: warning: variable 'lock1' set but not used
> [-Wunused-but-set-variable]
> examples/ex_logo.c: In function 'render':
> examples/ex_logo.c:318:30: warning: variable 'lock' set but not used
> [-Wunused-but-set-variable]
> examples/ex_logo.c:368:14: warning: variable 'h' set but not used
> [-Wunused-but-set-variable]
> examples/ex_logo.c:368:11: warning: variable 'w' set but not used
> [-Wunused-but-set-variable]
>
> examples/ex_prim.c: In function 'main':
> examples/ex_prim.c:487:18: warning: variable 'white' set but not used
> [-Wunused-but-set-variable]
>
> examples/ex_rotate.c: In function 'main':
> examples/ex_rotate.c:23:8: warning: variable 'bmp_h' set but not used
> [-Wunused-but-set-variable]
> examples/ex_rotate.c:22:8: warning: variable 'bmp_w' set but not used
> [-Wunused-but-set-variable]
>
> examples/ex_threads2.c: In function 'thread_func':
> examples/ex_threads2.c:156:11: warning: variable 'w' set but not used
> [-Wunused-but-set-variable]
>
> docs/scripts/trex.c: In function 'trex_element':
> docs/scripts/trex.c:275:7: warning: variable 'op' set but not used
> [-Wunused-but-set-variable]
>
> docs/scripts/trex.c: In function 'trex_element':
> docs/scripts/trex.c:275:7: warning: variable 'op' set but not used
> [-Wunused-but-set-variable]
>
> docs/scripts/trex.c: In function 'trex_element':
> docs/scripts/trex.c:275:7: warning: variable 'op' set but not used
> [-Wunused-but-set-variable]
>
> docs/scripts/trex.c: In function 'trex_element':
> docs/scripts/trex.c:275:7: warning: variable 'op' set but not used
> [-Wunused-but-set-variable]
>
> docs/scripts/trex.c: In function 'trex_element':
> docs/scripts/trex.c:275:7: warning: variable 'op' set but not used
> [-Wunused-but-set-variable]
>
> docs/scripts/trex.c: In function 'trex_element':
> docs/scripts/trex.c:275:7: warning: variable 'op' set but not used
> [-Wunused-but-set-variable]
>
> docs/scripts/trex.c: In function 'trex_element':
> docs/scripts/trex.c:275:7: warning: variable 'op' set but not used
> [-Wunused-but-set-variable]
>

Best regards,
Tobias Hansen




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/