Re: [AD] Allegro in Debian

[Peter Wang <novalazy@xxxxxxxxxx>]

On Sat, 07 Jul 2012 01:48:11 +0200, Tobias Hansen <tobias.han@xxxxxxxxxx> wrote:
> Hi,
> 
> there are some news on Allegro in Debian. Allegro 4.4 made it into
> Debian and will be in the next Debian and Ubuntu releases. We have not
> found a sponsor (a Debian Developer who uploads the package) for Allegro
> 5 yet.
> 
> I have some more patches for you. This one fixes some spelling mistakes
> in the Allegro 5 documentation:
> 
> http://anonscm.debian.org/gitweb/?p=pkg-games/allegro5.git;a=blob;f=debian/patches/fix-manpages.patch;hb=HEAD

Applied.

> 
> And here are the patches that are currently applied to Allegro 4.4:
> 
> http://anonscm.debian.org/gitweb/?p=pkg-games/allegro4.4.git;a=tree;f=debian/patches;hb=HEAD

I'll try to look at these later.

> 
> Please include as many as possible. If you have comments, they are also
> welcome. Some patches are from the old Allegro 4.2 package and we were
> not exactly sure if everything was still needed.
> 
> Four Allegro 5 tests are failing in a i386 chroot on a amd64 host (with
> --no-display). Can someone test if this happens generally on i386?
> 
> FAIL test hl thick-50 [sw] - hash=62819701
> FAIL test hl thick-50 clip [sw] - hash=a601764e
> FAIL test hl nolight [sw] - hash=9889e6b5
> FAIL test hl nolight clip [sw] - hash=85600dc7

Works on http://alleg.de/tests.py

It's probably just a small floating point difference.  You can send the
failing test output.  Run in the build/tests directory:

    ./test_driver -s ../../tests/test_prim.ini

> The file examples/ex_joystick_hotplugging.c has the executable flag set.
> Would you fix that for the next release?

Fixed.

> And some comments from Debian Developer Paul Wise, who reviewed the
> Allegro 5 package and might sponsor it when he is satisfied:
> 
> Am 04.07.2012 00:59, schrieb Paul Wise:
> >
> > addons/acodec/ogg.c and addons/acodec/flac.c has a copyright holder,
> > but no license, I guess it is zlib?
> >
> > Many of the source files reference readme.txt instead of LICENSE.txt.
> >
> > You might want to point upstream at this blog post:
> >
> >
> http://tieguy.org/blog/2012/03/17/on-the-importance-of-per-file-license-information/

We'll see.

> > Embedded copies of (parts) of other projects:
> >
> > docs/tools/trex.*: http://tiny-rex.sourceforge.net/
> > docs/src/autosuggest.js:
> > http://www.codeproject.com/KB/scripting/AutoSuggestControl.aspx
> > bstrlib.*: http://bstring.sourceforge.net/
> > examples/data/DejaVuSans*: http://dejavu-fonts.org/
> >
> > There are some generated files that should probably be removed from
> > the upstream tarball and created at build time instead. At the very
> > least the build system should automatically recreate them if they are
> > missing and the Debian package should remove them before starting the
> > build.
> >
> > src/scanline_drawers.c src/convert.c
> > include/allegro5/opengl/GLext/*gl*_ext_alias.h
> > include/allegro5/internal/aintern_convert.h docs/man/ docs/html/
> > docs/src/refman/images/*.png

Do what you want.

> > Some of the stuff looks like it might be missing source. In particular:
> >
> > addons/primitives/directx_shaders.c: contains precompiled shaders

The source seems to be in comments.  Might be nice to have them in
separate files, but we would still keep the precompiled form.

> >
> > allegro.pcx: some sort of 3D scene, I guess it is not meant to be
> > modified, but if it is then it is missing a rendering script, a font
> > and the models/textures for the rest of the scene.
> >
> > fakeamp.tga *font.tga green.tga: have some pre-rendered text in them,
> > some of which look like they are vector fonts, might be missing the
> > font(s) and a script to render them.
> >
> > mysha.tga and mysha256x256.png are modified versions of mysha.pcx, I
> > guess these can't be built automatically though.
> >
> > examples/data/DejaVuSans.ttf: the source for the DejaVu font(s) are
> > some fontforge files.
> >
> > examples/data/haiku/*.png: look like some of them might have been
> > produced in a vector image program.
> >
> > examples/data/haiku/*.ogg: source for these are .wav files and are in
> > the tarball linked from here:
> >
> > http://www.allegro.cc/forums/thread/602636/844773
> >
> > demos/a5teroids/data/sfx/game_music.ogg: sounds like it was made from
> > something else.

Just example data.

> > cppcheck warnings:
> >
> > [examples/ex_acodec_multi.c:53]: (error) Memory leak: sample_data
> > [examples/ex_acodec_multi.c:46]: (error) Memory leak: sample

Not really worth fixing, and the example isn't great anyway.
Might delete it.

> > [examples/ex_blend2.cpp:110]: (error) Array 'rgba_label[2]' accessed
> > at index 2, which is out of bounds

Bug; fixed.

> > [examples/ex_drawpixels.c:75]: (error) Buffer access out-of-bounds: stars

False positive?

> > [misc/msvchelp.c:43]: (error) Resource leak: fout
> > [misc/vcvars.c:138]: (error) Buffer overrun possible for long cmd-line
> args

Obsolete programs.

> > [src/display.c:388]: (error) Possible null pointer dereference:
> > display - otherwise it is redundant to check if display is null at
> > line 392
> >

Bug; fixed.

> > pyflakes warnings:
> >
> > python/generate_python_ctypes.py:2: 'os' imported but unused
> > python/generate_python_ctypes.py:3: 'from ctypes import *' used;
> > unable to detect undefined names
> > python/generate_python_ctypes.py:314: local variable 'release' is
> > assigned to but never used
> > python/generate_python_ctypes.py:315: local variable 'version' is
> > assigned to but never used
> > python/checkdocs.py:19: undefined name 'options'
> > python/checkdocs.py:34: undefined name 'options'
> > python/checkdocs.py:88: undefined name 'options'
> > python/checkdocs.py:90: undefined name 'options'
> > python/checkdocs.py:167: undefined name 'options'
> > python/checkdocs.py:168: undefined name 'options'
> > python/checkdocs.py:173: undefined name 'options'
> > python/checkdocs.py:185: undefined name 'options'
> > python/checkdocs.py:190: local variable 'n' is assigned to but never used
> > python/ex_draw_bitmap.py:3: 'glob' imported but unused
> > python/ex_draw_bitmap.py:4: 'from random import *' used; unable to
> > detect undefined names
> > python/ex_draw_bitmap.py:5: 'from math import *' used; unable to
> > detect undefined names
> > python/ex_draw_bitmap.py:6: 'from ctypes import *' used; unable to
> > detect undefined names
> > python/ex_draw_bitmap.py:11: 'from allegro import *' used; unable to
> > detect undefined names

Elias?

> > misc/make_converters.py:179: unexpected indent
> >                 if (shift > 0):
> >                 ^

Bug; fixed.

> > misc/make_scanline_drawers.py:217: undefined name 'texture'
> > misc/make_scanline_drawers.py:257: undefined name 'texture'
> > misc/make_scanline_drawers.py:261: undefined name 'opaque'
> > misc/make_scanline_drawers.py:261: undefined name 'white'
> > misc/make_scanline_drawers.py:266: undefined name 'texture'
> > misc/make_scanline_drawers.py:274: undefined name 'opaque'
> > misc/make_scanline_drawers.py:330: undefined name 'texture'

False positives, I think.  Probably bad style.

> > misc/make_scanline_drawers.py:348: local variable 'vv_ofs' is assigned
> > to but never used
> > misc/make_scanline_drawers.py:348: local variable 'uu_ofs' is assigned
> > to but never used

False positive.

> > gcc warnings:
> >
> > In file included from src/tri_soft.c:23:0:
> > include/allegro5/internal/aintern_blend.h:43:6: warning: always_inline
> > function might not be inlinable [-Wattributes]
> > In file included from src/tri_soft.c:23:0:
> > include/allegro5/internal/aintern_blend.h:29:1: warning: always_inline
> > function might not be inlinable [-Wattributes]

Hmm.

> > src/x/xkeyboard.c: In function '_al_xwin_get_keyboard_mapping':
> > src/x/xkeyboard.c:606:10: warning: 'XKeycodeToKeysym' is deprecated
> > (declared at /usr/include/X11/Xlib.h:1695) [-Wdeprecated-declarations]

No hurry.

> > addons/primitives/line_soft.c: In function 'line_stepper':
> > addons/primitives/line_soft.c:412:19: warning: variable 'minor' set
> > but not used [-Wunused-but-set-variable]

False positive.

I think the rest of the warnings were fixed in the previous release.

Thanks.

Peter