| Re: [AD] Dynamic DirectSound loading |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On August 18, 2010, Michał Cichoń wrote:
> Are those spaces problematic for some reason? If yes I will try to avoid
> such modifications in the future.
Normally its just seen as useless and unneeded changes. Tends to clutter up
the patch, and makes it harder to see exactly what real changed were made.
Probably best to separate white space changes from regular. But its not
really that big of a deal.
> -----Original Message-----
> From: Trent Gamblin [mailto:trent@xxxxxxxxxx]
> Sent: Wednesday, August 18, 2010 9:51 PM
> To: Coordination of admins/developers of the game programming library
> Allegro Subject: Re: [AD] Dynamic DirectSound loading
>
> On 2010-08-18, at 8:47 AM, Michał Cichoń wrote:
> > One thing less to remember about. dsound.dll is loaded dynamically and
> > Allegro logging is used instead of TRACE()
> >
> > Changes in dsound.cpp:
> > - define ALLEGRO_DEBUG_CHANNEL()
> > - replace TRACE with ALLEGRO_DEBUG/INFO/WARN/ERROR
> > - load dsound.dll dynamically
> > - spaces before end of line was removed
>
> This one looks fine. I can give it a test run and apply.
>
>
> -------------------------------------------------------------------------
> ----- This SF.net email is sponsored by
>
> Make an app they can't live without
> Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev
> --
> https://lists.sourceforge.net/lists/listinfo/alleg-developers
>
> -------------------------------------------------------------------------
> ----- This SF.net email is sponsored by
>
> Make an app they can't live without
> Enter the BlackBerry Developer Challenge
> http://p.sf.net/sfu/RIM-dev2dev
--
Thomas Fjellstrom
tfjellstrom@xxxxxxxxxx