| Re: [AD] offscreen sub bitmaps revisited |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On Mon, 2010-06-21 at 15:37 -0500, Matthew Leverton wrote:
> On Mon, Jun 21, 2010 at 2:19 PM, Elias Pschernig
> <elias.pschernig@xxxxxxxxxx> wrote:
> > What kind of side effects?
> >
> I don't remember. It may have been with D3D. I just now removed the
> x/y<0 clip and basic drawing appeared to work in OpenGL. I'll play
> around with it more later.
>
> There is this:
>
> /* Note:
> * Drivers are guaranteed that the parent is not a subbitmap itself
> * and that the passed rectangle lies fully within the parent.
> */
>
> which would no longer be true. If for some reason it's problematic
> with some drivers, I don't mind if they return NULL. I think that's
> more useful than the odd cropping that currently takes place.
>
Yes. As far as I remember that comment is by me, just as a note what the
code was doing. When you remove the clipping code just remove the note
as well as it is no longer true. It only means that OpenGL and DX (we
don't have any other drivers anyway) implementations can't assume it any
longer... but at least OpenGL never did it seems.
--
Elias Pschernig <elias.pschernig@xxxxxxxxxx>