Re: [AD] fshook changes

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On 2009-01-22, Thomas Fjellstrom <tfjellstrom@xxxxxxxxxx> wrote:
> On January 22, 2009, Peter Wang wrote:
> > On 2009-01-22, Thomas Fjellstrom <tfjellstrom@xxxxxxxxxx> wrote:
> > > On January 22, 2009, Peter Wang wrote:
> > > > On 2009-01-21, Thomas Fjellstrom <tfjellstrom@xxxxxxxxxx> wrote:
> > >
> > > > Also, can I delete _al_fs_hook_create() etc.? They seem to only be used
> > > > in one place each and make the code harder to read.
> > >
> > > I created them so in the future if we have to change the implementation
> > > of vtable names, the code that uses them doesn't have to change.
> >
> > That would only be confusing if the macro names don't match the vtable
> > names.
> 
> They do now, somewhat. Who knows what changes might need to be made behind the 
> scenes later on. Right now if a vtable name changes, only the aintern_fshook.h 
> file needs changed. Once addons start needing that header, the macros may start 
> to be used in more places, infact, the stdio code should probably use them, 
> just in case one or more of the vtable methods was swapped out for some 
> reason, right now, it will ignore the handle's vtable once its in its own 
> code.

Sorry, I didn't understand that.

Peter





Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/