Re: [AD] fshook changes

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On 2009-01-22, Thomas Fjellstrom <tfjellstrom@xxxxxxxxxx> wrote:
> On January 22, 2009, Peter Wang wrote:
> > On 2009-01-21, Thomas Fjellstrom <tfjellstrom@xxxxxxxxxx> wrote:
> > > MOST of the work outlined is now done. The api rename probably needs
> > > work. I could use some input there, as to what everyone else would
> > > prefer.
> > >
> > > Some documentation needs updating, but man that was tedious. I'll get to
> > > the docs soon if someone doesn't beat me to it.
> >
> > If you don't mind, I will put prefixes on the fshook vtable methods.
> > Having method names the same as standard C functions is not nice.
> 
> I don't really mind. the members are hidden anyway, and only need to be 
> changed in one file.
> 
> > Also, can I delete _al_fs_hook_create() etc.? They seem to only be used
> > in one place each and make the code harder to read.
> 
> I created them so in the future if we have to change the implementation of 
> vtable names, the code that uses them doesn't have to change.

That would only be confusing if the macro names don't match the vtable
names.

Peter





Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/