Re: [AD] Renaming of functions in kcm_audio addon

[Peter Wang <novalazy@xxxxxxxxxx>]

On 2008-11-26, allefant <allefant@xxxxxxxxxx> wrote:
> On Wed, Nov 26, 2008 at 5:14 AM, Peter Wang <novalazy@xxxxxxxxxx> wrote:
> > On 2008-11-25, Evert Glebbeek <EGLEBBK@xxxxxx> wrote:
> >>
> >> al_is_channel_conf            al_channel_is_configured
> >> al_channel_count              al_channel_count
> >> al_depth_size                 al_depth_size
> >>
> >
> > al_get_channel_count
> > al_get_depth_size
> >
> > We should probably rename al_current_time() and al_key_down()
> > as well.
> >
> 
> Maybe it should be al_is_channel_configured() instead?

Doing a quick grep:

    al_event_queue_is_empty
    al_font_is_compatible_font
    al_fs_entry_isdir
    al_fs_entry_isfile
    al_fs_isdir
    al_fs_isfile
    al_is_bitmap_locked
    al_is_channel_conf
    al_is_compatible_bitmap
    al_is_keyboard_installed
    al_is_mouse_installed
    al_is_opengl_extension_supported
    al_is_sub_bitmap
    al_timer_is_started

It looks like (modulo module prefixes) al_is_* is more popular.

So
    al_event_queue_is_empty -> al_is_event_queue_empty
    al_timer_is_started	    -> al_is_timer_started
    al_key_down		    -> al_is_key_down
And
    al_current_time	    -> al_get_time
?

> I would be fine with exempting all al_get_...() functions from the
> verb-requirement and leave out the _get  - but we shouldn't have the
> _get in some and not in others. Either
> al_bitmap_width()/al_channel_count()/al_key_down() etc. for
> everything, or al_get_...() for everything.

Yes.

Peter