Re: [AD] SF.net SVN: alleg:[11050] allegro/branches/4.9/src

["Peter Hull" <peterhull90@xxxxxxxxxx>]

We do have <sys/types.h> on OS X,
ALLEGRO_HAVE_SYS_TYPES_H gets defined in al_cfg.h but AFAICS that file
never gets included, therefore it uses the 'fallback' definition of
off_t in fshook.h which is wrong.
I think an #include "al_cfg.h" is needed, but where?

Pete


On Sat, Oct 11, 2008 at 4:04 PM, Peter Hull <peterhull90@xxxxxxxxxx> wrote:
> Doesn't build on OS X 10.4:
>
> In file included from /Users/peterhull/Projects/allegro/4.9/src/fshook.c:21:
> /Users/peterhull/Projects/allegro/4.9/include/allegro5/fshook.h:25:
> error: conflicting types for 'off_t'
> /usr/include/sys/fcntl.h:87: error: previous declaration of 'off_t' was here
> make[2]: *** [CMakeFiles/alleg_static.dir/src/fshook.c.o] Error 1
>
> I'll look into it.
>
> Pete
>
> On Sat, Oct 11, 2008 at 2:54 AM, Peter Wang <novalazy@xxxxxxxxxx> wrote:
>> On 2008-10-10, Thomas Fjellstrom <tfjellstrom@xxxxxxxxxx> wrote:
>>> You've totally broken that one by removing those two calls. Sure, the
>>> variables are unused, but thats mainly because return values should probably
>>> be checked, and I didn't bother. GetModuleFileNameEx is what fills "path" in.
>>>
>>> Probably shouldn't rip things out willy nilly like that.
>>
>> Oops.
>>
>> Peter
>>
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> --
>> https://lists.sourceforge.net/lists/listinfo/alleg-developers
>>
>