Re: [AD] fshook patch

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On Tuesday 07 October 2008, Thomas Fjellstrom wrote:
> On Tuesday 07 October 2008, Peter Wang wrote:
> > On 2008-10-07, Thomas Fjellstrom <tfjellstrom@xxxxxxxxxx> wrote:
> > > > > Index: src/unix/usystem.c
> > > > > ===================================================================
> > > > > --- src/unix/usystem.c	(.../4.9)	(revision 11023)
> > > > > +++ src/unix/usystem.c	(.../4.9-fshook)	(revision 11023)
> > > > > @@ -21,12 +21,14 @@
> > > > >  #include <stdlib.h>
> > > > >  #include <string.h>
> > > > >  #include <sys/stat.h>
> > > > > +#include <sys/types.h>
> > > > > +#include <pwd.h>
> > > >
> > > > Might as well wrap with ALLEGRO_HAVE_SYS_TYPES_H
> > >
> > > Do you mind if I just remove that sys/types.h include? the fshook.h
> > > include lower down pulls it in, and typedef's off_t if it wasn't seen.
> > > I don't really want to put that code in two places, since it'll
> > > conflict.
> >
> > No worries.  It's just something I thought of while browsing through.
>
> Ok. Though what I find really strange is that readme_a5.txt change.. I
> merged with 4.9 after the addition was made. It SHOULD have been merged
> into my branch already.

ah well, a simple `svn merge -c 11021 ../allegro-4.9` fixed that one.

> > Peter
>
> --
> Thomas Fjellstrom
> tfjellstrom@xxxxxxxxxx
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge Build the coolest Linux based applications with Moblin SDK & win
> great prizes Grand prize is a trip for two to an Open Source event anywhere
> in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/


-- 
Thomas Fjellstrom
tfjellstrom@xxxxxxxxxx




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/