Re: [AD] mis-matched realloc()/_AL_FREE() and _AL_MALLOC_ATOMIC()/free() in file.c |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On 2006-12-24, Andrei Ellman <ae-a-alleg@xxxxxxxxxx> wrote:
> Hi,
>
> I've finally been able to confirm with absolute certainty that the
> problem I reported with file.c has gone.
Thanks.
> However, I discovered
> mismatching _AL_MALLOC_ATOMIC()/free() and realloc()/_AL_FREE() pairs in
> pack_fopen_chunk(). The attatched patch replaces realloc() with
> _AL_REALLOC() and free() with _AL_FREE()
Committed.
> Also worth discussing is whether or not it's worth doing something about
> the '\/\' sequence in tmp_name.
AFAIK Thomas is interested in adding a tmpnam function (at the least) so
it may be irrelevant after that.
> IIRC, I think that on the Mac, tmp_name
> might contain a '//' sequence.
This should only be a problem if it occurs at the start of a path.
Peter