Re: [AD] binary compatibility check for 4.2.x

[Elias Pschernig <elias@xxxxxxxxxx>]

On Wed, 2006-03-08 at 22:33 +0100, Hans de Goede wrote:
> 
> Elias Pschernig wrote:
> > On Mon, 2006-03-06 at 00:32 +0100, Evert Glebbeek wrote:
> >>> The following patch fixes the version check problems on the 4.2.x
> >>> branch.  Older binaries will run with newer libraries, but newer
> >>> binaries will not run with older libraries.  That's still the policy
> >>> for 4.2.x, right?
> >> Right.
> >>
> >>> Was there anything else that needed to be done for 4.2.1?
> >> Elias and Hans are tracking an X11 bug that I still need to check if I can 
> >> reproduce here. Maybe it's not crucial to fix, but since it's a known bug 
> >> I figured that we might just as well fix it.
> >> Other than that I think that's it. I'll do a sweep of my list of marked 
> >> messages to make sure.
> >>
> > 
> > Maybe we can fix this for 4.2.1 still:
> > http://sourceforge.net/tracker/index.php?func=detail&aid=1401840&group_id=5665&atid=105665
> > 
> > It should be really simple from what I see, just need to replace the
> > hardcoded pathes with the one given in ./configure --prefix. I may get
> > around to write a patch tomorrow.
> > 
> 
> That would be great, we currently patch around it in Fedora, please note 
> that using --prefix won't be enough though you really should use the 
> value for --libdir see our patch:
> --- allegro-4.2.0/src/unix/umodules.c.64bit     2006-02-26 
> 14:43:37.000000000 +
> +++ allegro-4.2.0/src/unix/umodules.c   2006-02-26 14:44:26.000000000 +0100
> @@ -44,7 +44,12 @@
>   /* where to look for modules.lst */
>   static char *module_path[] =
>   {
> -   "/usr/local/lib/allegro/", "/usr/lib/allegro/", NULL
> +#ifdef __LP64__
> +   "/usr/lib64/allegro/",
> +#else
> +   "/usr/lib/allegro/",
> +#endif
> +   NULL
>   };
> 
> Notice how we use /usr/lib/xxxx for 32 bit and /usr/lib64/xxxx for 64 
> bit, although this patch works the correct fix really would be using the 
> libdir as set bu ./configure.
> 

Hm, ok, my idea of just having autoconf put the string into alunixac.h
apparently doesn't work, I only get this in the header, in some
variations :P

#define ALLEGRO_MODULES_DIR "$libdir/allegro"

Since you know much more about this than me - what would be the proper
way to do it?

-- 
Elias Pschernig