Re: [AD] RC1 - OSX - :(

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On Saturday 20 August 2005 13:28, Peter Hull wrote:
> On Friday 19 August 2005 23:55, Evert Glebbeek wrote:
> > I distinctly remember we had a very similar problem a while back and we
> > solved it. Do you remember the details?
> Didn't you just add Objective-C support to your gcc?

That was part of the problem, but a missing #ifdef SCAN_DEPEND in pcpu.m 
was another problem.
The offending lines were introduced in this patch:

Revision 1.29  - (view) (download) (annotate) - [select for diffs]
Sun Jul 24 04:41:18 2005 UTC (3 weeks, 6 days ago) by tjaden
Branch: MAIN
CVS Tags: v4-2-0-rc1, HEAD
Changes since 1.28: +66 -0 lines
Diff to previous 1.28

Peter Hull fixed the MacOS X port to avoid an issue with the dead bootstrap
context [1].  The patch also cleans up the dock notification code, and 
allows
command line apps (with SYSTEM_NONE) to run without the dock being notified 
at
all (resulting in faster start-up times, and avoiding Dock crashes if apps
start and terminate very quickly).

No other ObjectiveC source includes system headers directly (apart from 
pcpu.m) and so it isn't instantly obvious that the #ifndef SCAN_DEPEND 
guard is needed.

Patch attached (already applied).

Evert
Index: src/macosx/system.m
===================================================================
RCS file: /cvsroot/alleg/allegro/src/macosx/system.m,v
retrieving revision 1.29
diff -u -r1.29 system.m
--- src/macosx/system.m	24 Jul 2005 04:41:18 -0000	1.29
+++ src/macosx/system.m	20 Aug 2005 21:36:36 -0000
@@ -24,9 +24,11 @@
    #error something is wrong with the makefile
 #endif
 
+#ifndef SCAN_DEPEND
 #include <CoreFoundation/CoreFoundation.h>
 #include <mach/mach_port.h>
 #include <servers/bootstrap.h>
+#endif
 
 
 /* These are used to warn the dock about the application */


Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/