Re: [AD] [PATCH] Solaris Fixes and dev notes |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
> However, in the
> latest CVS checkout I still have one compilation problem I had to fix,
> relating to split_modex_screen not being defined.
I know, it still needs to be fixed.
> The patch I used to
> workaround this is attached. Obviously there may be a correct fix that
> I don't know about, just sending you what I used.
Thanks, but I think the correct solution was already agreed on. To
summarise: GFX_HAS_VGA is mainly an internal symbol for Allegro and
shouldn't be used by other programmes. The problem is that GFX_MODEX is
always defined on all UNIX systems because Linux can have it, but the modex
functions are only defined if the system in question is actually capable of
displaying VGA graphics. Since GFX_MODEX is defined on all UNIX systems, so
must all the modex functions.
(With the risk of repeating myself ad nauseam, I still think it's ludicrous
that all UNIX systems have a MODEX driver).
The solution is to provide platform-independent modex functions that do
nothing for systems where GFX_MODEX exists and GFX_HAS_VGA is not defined.
I don't think there was agreement yet on which sourcefile these should be
put in. My vote would be for something like src/misc/dummymx.c. All that's
needed is that someone writes that file, updates the makefile and submits a
patch.
We'll have to wait for the OS X problems Ultio reported on ACC to get
themselves fixed before we can release RC1 anyway, so I didn't push very
hard for this yet.
Evert