| Re: [AD] [PATCH] Solaris Fixes and dev notes |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
> There were a few small problems in the patch, I've corrected them, and
> made one more change to make this even more robust. See attached
> patch.
Could you elaborate a bit on what you changed?
- #ifdef ALLEGRO_HAVE_PROCFS_ARGCV
No, this is wrong. The pr_argv field is not portable to all systems, we
need the configure check.
+ if (psinfo.pr_argv && psinfo.pr_argc) {
This should be ok, but I'm puzzled: surely, if pr_argv is not NULL it has
to point to something? Why the extra check against pr_argc?
Evert