Re: [AD] ModeX fix

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On Monday 20 June 2005 13:59, Peter Wang wrote:
> Here's updated patches.  The first patch is the same as before, with
> comments.  I've tested it here and it seems alright.

[...]

> The second patch deprecates split_modex_screen() and removes any trace
> of them from the examples and documentation.
> 
> Commit them one after the other, if they're okay.

Done.

> PS. No one seems to have noticed that the ModeX driver cannot work in
> C-only mode, and apparently never has!  It uses asm bank switchers,
> which have a different calling convention to what is expected in C-only
> mode.  A few more #ifdefs in modex.c can't hurt...

Hmm... actually, I pretty much assumed that it wouldn't work in C only-mode 
and never bothered to check if Allegro agrees that it doesn't work.
On the bright side, no one seems to have noticed this these past few years 
anyway.
I agree though, some extra tests would be good. I'm not sure I want to see 
more #ifdefs in modex.c though. ;)

Evert




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/