Re: [AD] 4.2.0 Beta 3 woes

[Chris <chris.kcat@xxxxxxxxxx>]

Elias Pschernig wrote:
> On Fri, 2005-06-03 at 00:45 +0200, Evert Glebbeek wrote:
>
>
> > > The GFX_HAS_VGA is the intended fix though right now, right? So it
> > > should be applied for test.c and that example..

Isn't GFX_HAS_VGA internal? That's one of the reasons why I made it so 
platform specific drivers are always defined for their given platform, 
regardless of useability, to lessen the use of define-dependant code.

The problem is modex.c's #if-checking.. it's an absolute mess and nearly 
impossible to account for all cases (so as to make sure the function is 
compiled to do nothing instead of skipped out-right). And on top of the 
different cases,that code is compiled twice (once for the base lib, and 
again for the module) so it becomes that much harder to avoid 
duplicating the function. Plus, it seems non-Linux can't have VGA/ModeX 
in a module so it has that special case too.