Re: [AD] Allegro 4.2 beta 2 proposal

[Elias Pschernig <elias@xxxxxxxxxx>]

On Sun, 2005-04-10 at 16:25 +0200, Evert Glebbeek wrote:
> I think most bugs and problems that were reported have been fixed or at 
> least looked into. So, I think it makes sense to try and release a second 
> beta in the near future.
> Let's attempt a deadline of friday the 15th for all fixes and updates we 
> need to apply, I think that's doable.
> I don't actually know if I have time to do the release on the 15th and I'm 
> sure I won't have time on the 16th and probably the 17th, in which case it 
> would be on the 20th. That should still be fine though.
> Comments/suggestions?
> 

Yes, sounds good. It still bothers me that I made that stupid bug in
wkeybd.c and forgot about win98, for beta1.. so it's good to have this
fixed in beta2 :)

This reminds me, under my windows XP, there are 2 problems with the
examples, both only with the DXWN driver:

ex12bit: Only the left half of the screen is updated. It does some evil
hacking with the screen vtable, so probably we should expect it.. but
still, we need to either remove ex12bit (or at least the screen vtable
hacking part), or find a fix (probably only possible by understanding
how the screen is updated in the DX driver).

ex3buf: It is broken in windowed mode. Seems to have something to do
with the focus (so probably related to the window focus related problems
on allegro.cc). When I click another window, then back to the ex3buf
window, it does a single update of the window.

Both work fine in fullscreen (that must be the reason why we got no
specific bug reports yet.. they are fullscreen by default). I just
wanted to mention this, in case I find no time myself to look into it.
It shouldn't delay beta2.. we just should try to fix it for 4.2.0.

Oh, and attached is a patch to find mistakes for LOCK_VARIABLE and
LOCK_FUNCTION.. not that it really should matter with them gone in
4.3.x, so my LOCK_VARIABLE(midi_frequency) was probably the last chance
to mess up :P

-- 
Elias Pschernig

Index: include/allegro/internal/alconfig.h
===================================================================
RCS file: /cvsroot/alleg/allegro/include/allegro/internal/alconfig.h,v
retrieving revision 1.18
diff -u -p -r1.18 alconfig.h
--- include/allegro/internal/alconfig.h	10 Mar 2005 18:32:54 -0000	1.18
+++ include/allegro/internal/alconfig.h	10 Apr 2005 14:37:16 -0000
@@ -217,8 +217,8 @@
    #define LOCK_DATA(d, s)
    #define LOCK_CODE(c, s)
    #define UNLOCK_DATA(d, s)
-   #define LOCK_VARIABLE(x)
-   #define LOCK_FUNCTION(x)
+   #define LOCK_VARIABLE(x) (void)x
+   #define LOCK_FUNCTION(x) (void)x
 #endif
 
 
Index: src/timer.c
===================================================================
RCS file: /cvsroot/alleg/allegro/src/timer.c,v
retrieving revision 1.20
diff -u -p -r1.20 timer.c
--- src/timer.c	14 Mar 2005 11:41:59 -0000	1.20
+++ src/timer.c	10 Apr 2005 14:37:16 -0000
@@ -526,7 +526,9 @@ int install_timer(void)
    LOCK_VARIABLE(timer_driver);
    LOCK_VARIABLE(timer_delay);
    LOCK_VARIABLE(_timer_queue);
+#ifndef ALLEGRO_MULTITHREADED
    LOCK_VARIABLE(timer_semaphore);
+#endif
    LOCK_VARIABLE(vsync_counter);
    LOCK_VARIABLE(_timer_use_retrace);
    LOCK_VARIABLE(_retrace_hpp_value);