Re: [AD] Empty Datafile Bug

[Elias Pschernig <elias@xxxxxxxxxx>]

On Sun, 2005-04-24 at 01:22 +0200, Evert Glebbeek wrote:
> > Well, it's not a real problem, just somewhat annoying, comparable to
> > something like a typo in a comment. I usually fix them when they are
> > near somewhat else I edit (and as usually introduce both typos and empty
> > lines myself as well :P). Anyway, what exactly are the reasons against
> > it? I suppose, it has to do with merging branches in CVS?
> 
> It (potentially) screws up patches and diffs against older versions.

Ah, yes, of course :|

> So have I. Unfortunately, it's going to cause the same problem as above but
> on a larger scale: it's going to break every single older patch there is
> and completely destroy the ability to do a meaningful diff to an older
> version - that's why we can't do this.
> I think that for new source files in the new_api_branch/4.3, we can just
> use spaces and so weed out the 8 space tabs gradually.
> 

Yeah. The only place to do it otherwise would be when the current
new_api_branch gets CVS head again - assuming that you rarly would track
changes across that boundary, since there's that big merge change anyway
(or maybe I'm somehow thinking wrong about the end of new_api_branch as
well).

But yeah, I see the problem now. Personally, I think the cleaner
tab-less code would outweigh the CVS diff problems, but not by far. So,
I agree with you - let's just change the preferred style to not use any
tabs, but don't modify existing code just for that.

-- 
Elias Pschernig