Re: [AD] make install DEBUGMODE=1 failure

[Daniel Schlyder <daniel@xxxxxxxxxx>]

Evert Glebbeek:
> Just one final question about this part:

> +ifneq (,$(INSTALL_DIRS))
> +    ifdef UNIX_TOOLS
> +               mkdir $(MKDIR_OPTS) $(INSTALL_DIRS)
> +    else
> +        define MKDIRS
> +        $(foreach file,$(INSTALL_DIRS),md $(file)
> +        )
> +        endef
> +               $(MKDIRS)
> +    endif
> +endif

> Couldn't that read

> +ifneq (,$(INSTALL_DIRS))
> +        define MKDIRS
> +        $(foreach file,$(INSTALL_DIRS),mkdir $(file) )
> +        endef
> +       $(MKDIRS)
> +endif

> thus elminating the extra choice for UNIX_TOOLS? The less special code we 
> need, the better if you ask me :)

Yes, of course. :) Should still use MKDIR_OPTS, though. (It is set by
makefile.osx.) Also, foreach's ending ')' must be on a separate line for it
to work under Windows CLI.

Revised patch attached.

--
Daniel Schlyder
http://bitblaze.com/

Attachment: installall-2.diff
Description: Binary data