Re: x color conversion [Was: Re: [AD] minor fix]

["Elias Pschernig" <eliaspschernig@xxxxxxxxxx>]

[SourceForge doesn't send me mails anymore (including confirmation to my
attempt to re-subscribe), luckily I found an old backup subscription to a
webmail service which i can use in the meantime]
> On Friday 09 July 2004 12:47, Evert Glebbeek wrote:
> > Ok, I investigated a bit further and it seems the problem is related to 
> > the set_color() function. If I change the colour from grey to white in 
> > line 1037, the GUI shows up normally, but in grey rather than in white.
> I 
> > suspect it's a scaling issue between 8 bit and 6 bit RGB values. I'll 
> take 
> > a closer look at the code for set_color() if I have time.
> 
> Ok, problem solved. The problem was in _xwin_private_set_palette_range and
> only appears when X uses BGR instead of RGB ordering.
> The set_color() function calls this code with the from and to range equal,
> something which the new code did not allow (but could handle fine).
> I also fixed a bug that caused the incorrect palette range to be copied 
> when from was not 0.
> 
> I'm going to apply the attached patch.
> 

I can confirm this patch fixes the problem for me.