Re: [AD] (still) a race condition in mixer.c

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


> I've attached the path I commited on mainline.

Attached is a follow-up for Windows and BeOS. It seems to works fine.
I didn't enable it for QNX because I can't currently test it and QNX is very 
sensitive to threading issues.

Angelo, do you think we should enable it for MacOS X too? The purpose is to 
avoid race conditions in the mixer on SMP systems.

-- 
Eric Botcazou
Index: include/allegro/platform/albcc32.h
===================================================================
RCS file: /cvsroot/alleg/allegro/include/allegro/platform/albcc32.h,v
retrieving revision 1.8
diff -u -r1.8 albcc32.h
--- include/allegro/platform/albcc32.h	18 Jan 2003 12:21:59 -0000	1.8
+++ include/allegro/platform/albcc32.h	26 Sep 2003 10:34:54 -0000
@@ -39,7 +39,7 @@
 #define ALLEGRO_WINDOWS
 #define ALLEGRO_I386
 #define ALLEGRO_LITTLE_ENDIAN
-#undef ALLEGRO_MULTITHREADED  /* FIXME */
+#define ALLEGRO_MULTITHREADED
 
 #ifdef ALLEGRO_USE_CONSOLE
    #define ALLEGRO_CONSOLE_OK
Index: include/allegro/platform/albecfg.h
===================================================================
RCS file: /cvsroot/alleg/allegro/include/allegro/platform/albecfg.h,v
retrieving revision 1.5
diff -u -r1.5 albecfg.h
--- include/allegro/platform/albecfg.h	18 Jan 2003 12:21:59 -0000	1.5
+++ include/allegro/platform/albecfg.h	26 Sep 2003 10:34:54 -0000
@@ -35,7 +35,7 @@
 #define ALLEGRO_LITTLE_ENDIAN
 #define ALLEGRO_CONSOLE_OK
 #define ALLEGRO_USE_CONSTRUCTOR
-#undef ALLEGRO_MULTITHREADED  /* FIXME */
+#define ALLEGRO_MULTITHREADED
 
 /* arrange for other headers to be included later on */
 #define ALLEGRO_EXTRA_HEADER     "allegro/platform/albeos.h"
Index: include/allegro/platform/almngw32.h
===================================================================
RCS file: /cvsroot/alleg/allegro/include/allegro/platform/almngw32.h,v
retrieving revision 1.10
diff -u -r1.10 almngw32.h
--- include/allegro/platform/almngw32.h	18 Jan 2003 12:21:59 -0000	1.10
+++ include/allegro/platform/almngw32.h	26 Sep 2003 10:34:54 -0000
@@ -37,7 +37,7 @@
 #define ALLEGRO_I386
 #define ALLEGRO_LITTLE_ENDIAN
 #define ALLEGRO_USE_CONSTRUCTOR
-#undef ALLEGRO_MULTITHREADED  /* FIXME */
+#define ALLEGRO_MULTITHREADED
 
 #ifdef ALLEGRO_USE_CONSOLE
    #define ALLEGRO_CONSOLE_OK
Index: include/allegro/platform/almsvc.h
===================================================================
RCS file: /cvsroot/alleg/allegro/include/allegro/platform/almsvc.h,v
retrieving revision 1.8
diff -u -r1.8 almsvc.h
--- include/allegro/platform/almsvc.h	7 Mar 2003 14:40:54 -0000	1.8
+++ include/allegro/platform/almsvc.h	26 Sep 2003 10:34:54 -0000
@@ -37,7 +37,7 @@
 #define ALLEGRO_WINDOWS
 #define ALLEGRO_I386
 #define ALLEGRO_LITTLE_ENDIAN
-#undef ALLEGRO_MULTITHREADED  /* FIXME */
+#define ALLEGRO_MULTITHREADED
 
 #ifdef ALLEGRO_USE_CONSOLE
    #define ALLEGRO_CONSOLE_OK


Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/