Re: [AD] bug report: allegro-4.1.6: static libraries linked into shared library

[Eric Botcazou <ebotcazou@xxxxxxxxxx>]

> I should have mentioned this:
> 	http://www.ufoot.org/liquidwar/
> During build it tries to create a datfile for itself by adding
> together datfiles it produced earlier, and this step fails for me.

I was able to reproduce it. Patch attached (already applied to the CVS tree).
Liquidwar 5.5.8 appears to work fine with the CVS head on Linux.

[To other Allegro developers]
It's again the infamous behaviour of for_each_file(), which aborts as soon as 
*allegro_errno is non-zero. Really, really, really annoying...

[To P.W.]
Hey Peter, did you contribute to every Allegro-related project on Earth ?

> Which tweak are you talking about?

The tweak that will be needed for moving the three objects files from the 
shared to the unsharable part of the library.

> In makefile.in, you have a test to check if liballeg's dir is
> mentioned in /etc/ld.so.conf -- this is unnecessary on at least
> NetBSD, if you use -rpath when linking (which is usually done);
> I think the same applies for Solaris, but I'm not sure.

You're right, the issue was already brought on the table by one of our Solaris 
testers (Henrik Schmidt). So the path to shared libraries is usually 
hardcoded in executables on NetBSD too ?

-- 
Eric Botcazou

--- /home/eric/cvs/allegro/tools/datedit.c	Tue Nov 26 14:36:30 2002
+++ allegro/tools/datedit.c	Fri Dec 20 17:05:14 2002
@@ -241,6 +241,10 @@
 
       pack_fclose(f);
    }
+   else {
+      /* don't let the error propagate */
+      errno = 0;
+   }
 }