[AD] dat tool save header patch - second try

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


To people with nice threaded e-mail clients. Sorry for starting new thread,
but if I reply my mail never gets through. Has happened for both conductors
and allegro lists. Could this be a mail server problem?

VPh> Just one thing I'm thinking of: I see you take the filename to build
VPh> the identifier. It might be better to take the whole path, and then
VPh> C/C++ identifierize the resultant name in case a project uses something
VPh> like npc/ids.h, objects/ids.h and maps/ids.h. Also, a valid filename is
VPh> not the same as a valid cpp identifier, so some encoding would be
VPh> needed anyway. Like a file can start with a number but an identifier
VPh> can't. Just a thought.

Yeah, I guess my solution was a bit too easy. Attached is a new patch that
uses whole path, replaces '.' and '/' chars with '_', and removes other
chars that aren't alpha-numeric. Also, prepends "DAT_" to make sure first
char is not a number. Is this one better?

-- 
Sincerely,
Daniel Schlyder

PS. Really looking forward to your Ogg lib, Vincent!

Attachment: datedit2.diff
Description: Binary data



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/